From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9D30C4740C for ; Mon, 23 Sep 2019 06:26:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C92A020640 for ; Mon, 23 Sep 2019 06:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393080AbfIWG0p (ORCPT ); Mon, 23 Sep 2019 02:26:45 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2766 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387519AbfIWG0p (ORCPT ); Mon, 23 Sep 2019 02:26:45 -0400 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 5298B51A67B9CB383767; Mon, 23 Sep 2019 14:26:43 +0800 (CST) Received: from [127.0.0.1] (10.184.213.217) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 23 Sep 2019 14:26:40 +0800 Subject: Re: [PATCH] fuse: fix memleak in cuse_channel_open To: , , , References: <1565769549-127890-1-git-send-email-zhengbin13@huawei.com> From: "zhengbin (A)" Message-ID: Date: Mon, 23 Sep 2019 14:26:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <1565769549-127890-1-git-send-email-zhengbin13@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.184.213.217] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org ping On 2019/8/14 15:59, zhengbin wrote: > If cuse_send_init fails, need to fuse_conn_put cc->fc. > > cuse_channel_open->fuse_conn_init->refcount_set(&fc->count, 1) > ->fuse_dev_alloc->fuse_conn_get > ->fuse_dev_free->fuse_conn_put > > Fixes: cc080e9e9be1 ("fuse: introduce per-instance fuse_dev structure") > Reported-by: Hulk Robot > Signed-off-by: zhengbin > --- > fs/fuse/cuse.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/fuse/cuse.c b/fs/fuse/cuse.c > index bab7a0d..f3b7208 100644 > --- a/fs/fuse/cuse.c > +++ b/fs/fuse/cuse.c > @@ -519,6 +519,7 @@ static int cuse_channel_open(struct inode *inode, struct file *file) > rc = cuse_send_init(cc); > if (rc) { > fuse_dev_free(fud); > + fuse_conn_put(&cc->fc); > return rc; > } > file->private_data = fud; > -- > 2.7.4 > > > . >