From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kay Sievers Subject: Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link Date: Thu, 28 May 2009 02:30:15 +0200 Message-ID: References: <1242865694-2100-1-git-send-email-ebiederm@xmission.com> <20090528001418.GA2499@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Eric W. Biederman" , Andrew Morton , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tejun Heo , Cornelia Huck , linux-fsdevel@vger.kernel.org, Benjamin Thery , Daniel Lezcano , "Eric W. Biederman" To: Greg KH Return-path: Received: from mail-fx0-f168.google.com ([209.85.220.168]:54824 "EHLO mail-fx0-f168.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbZE1Aaa (ORCPT ); Wed, 27 May 2009 20:30:30 -0400 In-Reply-To: <20090528001418.GA2499@kroah.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, May 28, 2009 at 02:14, Greg KH wrote: > > So, there's been a lot of talk in this thread. > > Eric, do you have an updated set of patches for me to try out? I think we should get a version of the patch in that removes all files in a directory on cleanup, but warn if a subdirectory is still there. James has a patch to fix the one issue we've seen so far with existing child directories. After that, we should work on fixing the users that leave files behind, and can possibly stop cleaning up files, if we want to. > Or are there still problems, like the "fry the ext3 boot partition" that > Kay found? That is unrelated to Eric's patches, They just added the dump, which I tried to trigger. It's not entirely clear what caused the filesytem damage, but I was definitely able to reproduce the unclean shutdown without any of Eric's sysfs patches. Thanks, Kay