From: Doug Ledford <dledford@redhat.com>
To: Richard Weinberger <richard@nod.at>,
Topi Miettinen <toiwoton@gmail.com>,
linux-kernel@vger.kernel.org
Cc: "Jonathan Corbet" <corbet@lwn.net>,
"Tony Luck" <tony.luck@intel.com>,
"Fenghua Yu" <fenghua.yu@intel.com>,
"Alexander Graf" <agraf@suse.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
"Paul Mackerras" <paulus@samba.org>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "Sean Hefty" <sean.hefty@intel.com>,
"Hal Rosenstock" <hal.rosenstock@gmail.com>,
"Mike Marciniszyn" <mike.marciniszyn@intel.com>,
"Dennis Dalessandro" <dennis.dalessandro@intel.com>,
"Christian Benvenuti" <benve@cisco.com>,
"Dave Goodell" <dgoodell@cisco.com>,
"Sudeep Dutt" <sudeep.dutt@intel.com>,
"Ashutosh Dixit" <ashutosh.dixit@intel.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"Alexander Viro" <viro@zeniv.linux.org.uk>,
"Tejun Heo" <tj@kernel.org>, "Li Zefan" <lizefan@huawei.com>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Balbir Singh" <bsingharora@gmail.com>,
"Markus Elfring" <elfring@users.sourceforge.net>,
"David S. Miller" <davem@davemloft.net>,
"Nicolas Dichtel" <nicolas.dichtel@6wind.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Konstantin Khlebnikov" <koct9i@gmail.com>,
"Jiri Slaby" <jslaby@suse.cz>,
"Cyrill Gorcunov" <gorcunov@openvz.org>,
"Michal Hocko" <mhocko@suse.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
"Michael Kerrisk" <mtk.manpages@gmail.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Marcus Gelderie" <redmnic@gmail.com>,
"Vladimir Davydov" <vdavydov@virtuozzo.com>,
"Joe Perches" <joe@perches.com>,
"Frederic Weisbecker" <fweisbec@gmail.com>,
"Andrea Arcangeli" <aarcange@redhat.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Andi Kleen" <ak@linux.intel.com>,
"Oleg Nesterov" <oleg@redhat.com>, "Stas Sergeev" <stsp@list.ru>,
"Amanieu d'Antras" <amanieu@gmail.com>,
"Wang Xiaoqiang" <wangxq10@lzu.edu.cn>,
"Helge Deller" <deller@gmx.de>,
"Mateusz Guzik" <mguzik@redhat.com>,
"Alex Thorlton" <athorlton@sgi.com>,
"Ben Segall" <bsegall@google.com>,
"John Stultz" <john.stultz@linaro.org>,
"Rik van Riel" <riel@redhat.com>,
"Eric B Munson" <emunson@akamai.com>,
"Alexey Klimov" <klimov.linux@gmail.com>,
"Chen Gang" <gang.chen.5i5j@gmail.com>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
"David Rientjes" <rientjes@google.com>,
"Hugh Dickins" <hughd@google.com>,
"Alexander Kuleshov" <kuleshovmail@gmail.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:IA64 (Itanium) PLATFORM" <linux-ia64@vger.kernel.org>,
"open list:KERNEL VIRTUAL MACHINE (KVM) FOR POWERPC"
<kvm-ppc@vger.kernel.org>,
"open list:KERNEL VIRTUAL MACHINE (KVM)" <kvm@vger.kernel.org>,
"open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)"
<linuxppc-dev@lists.ozlabs.org>,
"open list:INFINIBAND SUBSYSTEM" <linux-rdma@vger.kernel.org>,
"open list:FILESYSTEMS (VFS and infrastructure)"
<linux-fsdevel@vger.kernel.org>,
"open list:CONTROL GROUP (CGROUP)" <cgroups@vger.kernel.org>,
"open list:BPF (Safe dynamic programs and tools)"
<netdev@vger.kernel.org>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>
Subject: Re: [PATCH 00/14] Present useful limits to user (v2)
Date: Mon, 18 Jul 2016 17:25:09 -0400 [thread overview]
Message-ID: <ac74d6f7-8972-feae-8e7f-696b46386349@redhat.com> (raw)
In-Reply-To: <5788F0E1.8090203@nod.at>
[-- Attachment #1.1: Type: text/plain, Size: 2270 bytes --]
On 7/15/2016 10:19 AM, Richard Weinberger wrote:
> Hi!
>
> Am 15.07.2016 um 12:35 schrieb Topi Miettinen:
>> Hello,
>>
>> There are many basic ways to control processes, including capabilities,
>> cgroups and resource limits. However, there are far fewer ways to find out
>> useful values for the limits, except blind trial and error.
>>
>> This patch series attempts to fix that by giving at least a nice starting
>> point from the highwater mark values of the resources in question.
>> I looked where each limit is checked and added a call to update the mark
>> nearby.
>>
>> Example run of program from Documentation/accounting/getdelauys.c:
>>
>> ./getdelays -R -p `pidof smartd`
>> printing resource accounting
>> RLIMIT_CPU=0
>> RLIMIT_FSIZE=0
>> RLIMIT_DATA=18198528
>> RLIMIT_STACK=135168
>> RLIMIT_CORE=0
>> RLIMIT_RSS=0
>> RLIMIT_NPROC=1
>> RLIMIT_NOFILE=55
>> RLIMIT_MEMLOCK=0
>> RLIMIT_AS=130879488
>> RLIMIT_LOCKS=0
>> RLIMIT_SIGPENDING=0
>> RLIMIT_MSGQUEUE=0
>> RLIMIT_NICE=0
>> RLIMIT_RTPRIO=0
>> RLIMIT_RTTIME=0
>>
>> ./getdelays -R -C /sys/fs/cgroup/systemd/system.slice/smartd.service/
>> printing resource accounting
>> sleeping 1, blocked 0, running 0, stopped 0, uninterruptible 0
>> RLIMIT_CPU=0
>> RLIMIT_FSIZE=0
>> RLIMIT_DATA=18198528
>> RLIMIT_STACK=135168
>> RLIMIT_CORE=0
>> RLIMIT_RSS=0
>> RLIMIT_NPROC=1
>> RLIMIT_NOFILE=55
>> RLIMIT_MEMLOCK=0
>> RLIMIT_AS=130879488
>> RLIMIT_LOCKS=0
>> RLIMIT_SIGPENDING=0
>> RLIMIT_MSGQUEUE=0
>> RLIMIT_NICE=0
>> RLIMIT_RTPRIO=0
>> RLIMIT_RTTIME=0
>>
>> In this example, smartd is running as a non-root user. The presented
>> values can be used as a starting point for giving new limits to the
>> service.
>
> I don't think it is worth sprinkling the kernel with update_resource_highwatermark()
> calls just to get these metrics.
>
> Can't we teach the existing perf infrastructure to collect these highwatermarks for us?
I'm not sure about perf (I don't know the internals of perf well enough
to comment), but I'm sure the systemtap infrastructure could do this,
and a preconfigured systemtap script could be shipped with the package
that would allow this.
--
Doug Ledford <dledford@redhat.com>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2016-07-18 21:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 10:35 [PATCH 00/14] Present useful limits to user (v2) Topi Miettinen
2016-07-15 10:35 ` [PATCH 03/14] resource limits: track highwater mark of file sizes Topi Miettinen
2016-07-15 10:35 ` [PATCH 04/14] resource limits: track highwater mark of VM data segment Topi Miettinen
2016-07-15 10:35 ` [PATCH 06/14] resource limits: track highwater mark of cores dumped Topi Miettinen
2016-07-15 10:35 ` [PATCH 08/14] resource limits: track highwater mark of number of files Topi Miettinen
2016-07-15 12:43 ` [PATCH 00/14] Present useful limits to user (v2) Peter Zijlstra
2016-07-15 13:52 ` Topi Miettinen
2016-07-15 13:59 ` Peter Zijlstra
2016-07-15 16:57 ` Topi Miettinen
2016-07-15 20:54 ` H. Peter Anvin
2016-07-15 13:04 ` Balbir Singh
2016-07-15 16:35 ` Topi Miettinen
2016-07-18 22:05 ` Doug Ledford
2016-07-19 16:53 ` Topi Miettinen
2016-07-15 14:19 ` Richard Weinberger
2016-07-15 17:19 ` Topi Miettinen
2016-07-18 21:25 ` Doug Ledford [this message]
2016-08-03 18:20 ` Topi Miettinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac74d6f7-8972-feae-8e7f-696b46386349@redhat.com \
--to=dledford@redhat.com \
--cc=aarcange@redhat.com \
--cc=acme@kernel.org \
--cc=agraf@suse.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alex.williamson@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=amanieu@gmail.com \
--cc=aryabinin@virtuozzo.com \
--cc=ashutosh.dixit@intel.com \
--cc=ast@kernel.org \
--cc=athorlton@sgi.com \
--cc=benh@kernel.crashing.org \
--cc=benve@cisco.com \
--cc=bsegall@google.com \
--cc=bsingharora@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dan.carpenter@oracle.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=dennis.dalessandro@intel.com \
--cc=dgoodell@cisco.com \
--cc=ebiederm@xmission.com \
--cc=elfring@users.sourceforge.net \
--cc=emunson@akamai.com \
--cc=fenghua.yu@intel.com \
--cc=fweisbec@gmail.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=gorcunov@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=joe@perches.com \
--cc=john.stultz@linaro.org \
--cc=jslaby@suse.cz \
--cc=kirill.shutemov@linux.intel.com \
--cc=klimov.linux@gmail.com \
--cc=koct9i@gmail.com \
--cc=kuleshovmail@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lizefan@huawei.com \
--cc=mguzik@redhat.com \
--cc=mhocko@suse.com \
--cc=mike.marciniszyn@intel.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=mtk.manpages@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=redmnic@gmail.com \
--cc=richard@nod.at \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=rkrcmar@redhat.com \
--cc=sean.hefty@intel.com \
--cc=stsp@list.ru \
--cc=sudeep.dutt@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=toiwoton@gmail.com \
--cc=tony.luck@intel.com \
--cc=vbabka@suse.cz \
--cc=vdavydov@virtuozzo.com \
--cc=viro@zeniv.linux.org.uk \
--cc=wangxq10@lzu.edu.cn \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).