From: Denis Efremov <efremov@ispras.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>, Jan Kara <jack@suse.cz>,
Matthew Wilcox <matthew@wil.cx>,
linux-kernel@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org, linux-media@vger.kernel.org,
Erdem Tumurov <erdemus@gmail.com>,
Vladimir Shelekhov <vshel@iis.nsk.su>
Subject: Re: [PATCH] lib/memweight.c: optimize by inlining bitmap_weight()
Date: Thu, 22 Aug 2019 10:30:07 +0300 [thread overview]
Message-ID: <ad15bc93-0283-2518-8185-7683614d9965@ispras.ru> (raw)
In-Reply-To: <20190821182507.b0dea16f57360cf0ac40deb6@linux-foundation.org>
On 22.08.2019 04:25, Andrew Morton wrote:
> On Wed, 21 Aug 2019 10:42:00 +0300 Denis Efremov <efremov@ispras.ru> wrote:
>
>> This patch inlines bitmap_weight() call.
>
> It is better to say the patch "open codes" the bitmap_weight() call.
>
>> Thus, removing the BUG_ON,
>
> Why is that OK to do?
BUG_ON was necessary here to check that bitmap_weight will return a correct value,
i.e. the computed weight will fit the int type:
static __always_inline int bitmap_weight(const unsigned long *src, unsigned int nbits);
BUG_ON was added in the memweight v2
https://lore.kernel.org/lkml/20120523092113.GG10452@quack.suse.cz/
Jan Kara wrote:
>> +
>> + for (longs = bytes / sizeof(long); longs > 0; ) {
>> + size_t bits = min_t(size_t, INT_MAX & ~(BITS_PER_LONG - 1),
> + longs * BITS_PER_LONG);
> I find it highly unlikely that someone would have such a large bitmap
> (256 MB or more on 32-bit). Also the condition as you wrote it can just
> overflow so it won't have the desired effect. Just do
> BUG_ON(longs >= ULONG_MAX / BITS_PER_LONG);
> and remove the loop completely. If someone comes with such a huge bitmap,
> the code can be modified easily (after really closely inspecting whether
> such a huge bitmap is really well justified).
>> +
>> + w += bitmap_weight(bitmap.ptr, bits);
>> + bytes -= bits / BITS_PER_BYTE;
>> + bitmap.address += bits / BITS_PER_BYTE;
>> + longs -= bits / BITS_PER_LONG;
Akinobu Mita wrote:
> The bits argument of bitmap_weight() is int type. So this should be
>
> BUG_ON(longs >= INT_MAX / BITS_PER_LONG);
We don't need this check, since we removed the bitmap_weight call and
control the computation directly with size_t everywhere.
We could add BUG_ON(bytes >= SIZE_MAX / BITS_PER_BYTE);
at the very beginning of the function to check that the array is not
very big (>2000PiB), but it seems excessive.
>
> I expect all the code size improvements are from doing this?
Yes, but I thought it's good to show that the total size is not
increasing because of the manual "inlining".
>
>> and 'longs to bits -> bits to longs' conversion by directly calling
>> hweight_long().
>>
>> ./scripts/bloat-o-meter lib/memweight.o.old lib/memweight.o.new
>> add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-10 (-10)
>> Function old new delta
>> memweight 162 152 -10
>>
>
Regards,
Denis
next prev parent reply other threads:[~2019-08-22 7:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 7:42 [PATCH] lib/memweight.c: optimize by inlining bitmap_weight() Denis Efremov
2019-08-22 1:25 ` Andrew Morton
2019-08-22 7:30 ` Denis Efremov [this message]
2019-08-24 10:01 ` [PATCH v2] lib/memweight.c: open codes bitmap_weight() Denis Efremov
2019-08-25 6:11 ` Matthew Wilcox
2019-08-25 11:39 ` Denis Efremov
2019-08-26 18:39 ` Matthew Wilcox
2019-09-13 11:48 ` Denis Efremov
2019-09-13 13:41 ` efremov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad15bc93-0283-2518-8185-7683614d9965@ispras.ru \
--to=efremov@ispras.ru \
--cc=akinobu.mita@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dm-devel@redhat.com \
--cc=erdemus@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=vshel@iis.nsk.su \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).