From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7A5C4360C for ; Fri, 4 Oct 2019 22:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B062E222C0 for ; Fri, 4 Oct 2019 22:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570229238; bh=xzHJwRDpMutixnFislQvEBP/YT7jem/U/8kCBigrHuc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-ID:From; b=zAHe9FbN30bHgsUhL5qhIN4VF5VIbm4HVVwv9xNzn35UwUJ1re+MUAKmiyQwbL7iv 0QLCkA4hY62jF6G1XCGrocCrxAsCzIYyiUjwiQkDkS5InTGbfwg2e4yeYi+Q1zKNsT 15Y/VEr5SDSi9nXJmcdcbMwCUVqHojMrezy4NFIc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730070AbfJDWrP (ORCPT ); Fri, 4 Oct 2019 18:47:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:50258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbfJDWrO (ORCPT ); Fri, 4 Oct 2019 18:47:14 -0400 Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net [24.9.64.241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27C0D20873; Fri, 4 Oct 2019 22:47:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570229232; bh=xzHJwRDpMutixnFislQvEBP/YT7jem/U/8kCBigrHuc=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=iwzzgBVqn0QkoDuULW/O4NrloecUNaYOg0c99vmkwrF/zjed3x2bOMaHRqdx3FMcB x9c+A3rz+204+uJreaQuOoW8uMDh6bYqcKQgfB1jhKbgSV/JJFS70YgyJLCTDDtbp8 DUCzwKxib6rwVWWLjRz787WWmuX5+RAponaYusdk= Subject: Re: [PATCH v18 00/19] kunit: introduce KUnit, the Linux kernel unit testing framework To: Brendan Higgins Cc: Linus Torvalds , "Theodore Y. Ts'o" , Frank Rowand , Greg Kroah-Hartman , Josh Poimboeuf , Kees Cook , kieran.bingham@ideasonboard.com, Luis Chamberlain , Peter Zijlstra , robh@kernel.org, Stephen Boyd , Masahiro Yamada , devicetree@vger.kernel.org, dri-devel , kunit-dev@googlegroups.com, "open list:DOCUMENTATION" , linux-fsdevel , Linux Kbuild mailing list , Linux Kernel Mailing List , "open list:KERNEL SELFTEST FRAMEWORK" , linux-nvdimm , linux-um@lists.infradead.org, Sasha Levin , Tim.Bird@sony.com, Amir Goldstein , Dan Carpenter , Daniel Vetter , jdike@addtoit.com, Joel Stanley , Julia Lawall , khilman@baylibre.com, knut.omang@oracle.com, logang@deltatee.com, Michael Ellerman , Petr Mladek , Randy Dunlap , Richard Weinberger , David Rientjes , Steven Rostedt , wfg@linux.intel.com, shuah References: <20190923090249.127984-1-brendanhiggins@google.com> <20191004213812.GA24644@mit.edu> <56e2e1a7-f8fe-765b-8452-1710b41895bf@kernel.org> <20191004222714.GA107737@google.com> From: shuah Message-ID: Date: Fri, 4 Oct 2019 16:47:09 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191004222714.GA107737@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 10/4/19 4:27 PM, Brendan Higgins wrote: > On Fri, Oct 04, 2019 at 03:59:10PM -0600, shuah wrote: >> On 10/4/19 3:42 PM, Linus Torvalds wrote: >>> On Fri, Oct 4, 2019 at 2:39 PM Theodore Y. Ts'o wrote: >>>> >>>> This question is primarily directed at Shuah and Linus.... >>>> >>>> What's the current status of the kunit series now that Brendan has >>>> moved it out of the top-level kunit directory as Linus has requested? >>> >> >> The move happened smack in the middle of merge window and landed in >> linux-next towards the end of the merge window. >> >>> We seemed to decide to just wait for 5.5, but there is nothing that >>> looks to block that. And I encouraged Shuah to find more kunit cases >>> for when it _does_ get merged. >>> >> >> Right. I communicated that to Brendan that we could work on adding more >> kunit based tests which would help get more mileage on the kunit. >> >>> So if the kunit branch is stable, and people want to start using it >>> for their unit tests, then I think that would be a good idea, and then >>> during the 5.5 merge window we'll not just get the infrastructure, >>> we'll get a few more users too and not just examples. > > I was planning on holding off on accepting more tests/changes until > KUnit is in torvalds/master. As much as I would like to go around > promoting it, I don't really want to promote too much complexity in a > non-upstream branch before getting it upstream because I don't want to > risk adding something that might cause it to get rejected again. > > To be clear, I can understand from your perspective why getting more > tests/usage before accepting it is a good thing. The more people that > play around with it, the more likely that someone will find an issue > with it, and more likely that what is accepted into torvalds/master is > of high quality. > > However, if I encourage arbitrary tests/improvements into my KUnit > branch, it further diverges away from torvalds/master, and is more > likely that there will be a merge conflict or issue that is not related > to the core KUnit changes that will cause the whole thing to be > rejected again in v5.5. > The idea is that the new development will happen based on kunit in linux-kselftest next. It will work just fine. As we accepts patches, they will go on top of kunit that is in linux-next now. thanks, -- Shuah