From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from szxga05-in.huawei.com ([45.249.212.191]:11018 "EHLO
        szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751460AbdKVDvI (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 21 Nov 2017 22:51:08 -0500
Subject: Re: [PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get
 one victim
To: <jaegeuk@kernel.org>, <chao@kernel.org>, <yuchao0@huawei.com>,
        <yunlong.song@icloud.com>
CC: <miaoxie@huawei.com>, <bintian.wang@huawei.com>,
        <linux-fsdevel@vger.kernel.org>,
        <linux-f2fs-devel@lists.sourceforge.net>,
        <linux-kernel@vger.kernel.org>
References: <1510880948-154538-1-git-send-email-yunlong.song@huawei.com>
From: Yunlong Song <yunlong.song@huawei.com>
Message-ID: <ad823d10-ac5c-095d-2eb6-5f84c559a098@huawei.com>
Date: Wed, 22 Nov 2017 11:50:10 +0800
MIME-Version: 1.0
In-Reply-To: <1510880948-154538-1-git-send-email-yunlong.song@huawei.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

ping again...

On 2017/11/17 9:09, Yunlong Song wrote:
> This can help to find potential bugs on some corner case.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>   fs/f2fs/gc.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 5d5bba4..c89128b 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -1035,6 +1035,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync,
>   		goto stop;
>   	}
>   	if (!__get_victim(sbi, &segno, gc_type)) {
> +		f2fs_bug_on(sbi, !total_freed && has_not_enough_free_secs(sbi, 0, 0));
>   		ret = -ENODATA;
>   		goto stop;
>   	}

-- 
Thanks,
Yunlong Song