From: Jeff Layton <jlayton@kernel.org>
To: Deepa Dinamani <deepa.kernel@gmail.com>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, arnd@arndb.de,
ceph-devel@vger.kernel.org, Ilya Dryomov <idryomov@gmail.com>
Subject: Re: [PATCH v2 3/6] fs: ceph: Delete timespec64_trunc() usage
Date: Tue, 03 Dec 2019 13:55:04 -0500 [thread overview]
Message-ID: <aef16571cebc9979c73533c98b6b682618fd64a8.camel@kernel.org> (raw)
In-Reply-To: <20191203051945.9440-4-deepa.kernel@gmail.com>
On Mon, 2019-12-02 at 21:19 -0800, Deepa Dinamani wrote:
> Since ceph always uses ns granularity, skip the
> truncation which is a no-op.
>
> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
> Cc: jlayton@kernel.org
> Cc: ceph-devel@vger.kernel.org
> ---
> fs/ceph/mds_client.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> index 068b029cf073..88687ed65cff 100644
> --- a/fs/ceph/mds_client.c
> +++ b/fs/ceph/mds_client.c
> @@ -2069,7 +2069,6 @@ struct ceph_mds_request *
> ceph_mdsc_create_request(struct ceph_mds_client *mdsc, int op, int mode)
> {
> struct ceph_mds_request *req = kzalloc(sizeof(*req), GFP_NOFS);
> - struct timespec64 ts;
>
> if (!req)
> return ERR_PTR(-ENOMEM);
> @@ -2088,8 +2087,7 @@ ceph_mdsc_create_request(struct ceph_mds_client *mdsc, int op, int mode)
> init_completion(&req->r_safe_completion);
> INIT_LIST_HEAD(&req->r_unsafe_item);
>
> - ktime_get_coarse_real_ts64(&ts);
> - req->r_stamp = timespec64_trunc(ts, mdsc->fsc->sb->s_time_gran);
> + ktime_get_coarse_real_ts64(&req->r_stamp);
>
> req->r_op = op;
> req->r_direct_mode = mode;
Thanks Deepa. We'll plan to take this one in via the ceph tree.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2019-12-03 18:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 5:19 [PATCH v2 0/6] Delete timespec64_trunc() Deepa Dinamani
2019-12-03 5:19 ` [PATCH v2 1/6] fs: fat: Eliminate timespec64_trunc() usage Deepa Dinamani
2019-12-03 5:19 ` [PATCH v2 2/6] fs: cifs: Delete usage of timespec64_trunc Deepa Dinamani
2019-12-03 5:19 ` [PATCH v2 3/6] fs: ceph: Delete timespec64_trunc() usage Deepa Dinamani
2019-12-03 18:55 ` Jeff Layton [this message]
2019-12-03 19:41 ` Deepa Dinamani
2019-12-03 19:49 ` Jeff Layton
2019-12-03 5:19 ` [PATCH v2 4/6] fs: ubifs: Eliminate " Deepa Dinamani
2019-12-03 5:19 ` [PATCH v2 5/6] fs: Delete timespec64_trunc() Deepa Dinamani
2019-12-03 5:19 ` [PATCH v2 6/6] fs: Do not overload update_time Deepa Dinamani
2019-12-06 2:43 ` [PATCH v2 0/6] Delete timespec64_trunc() Deepa Dinamani
2019-12-07 6:02 ` Al Viro
2019-12-08 2:04 ` Deepa Dinamani
2019-12-08 3:04 ` Al Viro
2019-12-09 0:48 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aef16571cebc9979c73533c98b6b682618fd64a8.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=arnd@arndb.de \
--cc=ceph-devel@vger.kernel.org \
--cc=deepa.kernel@gmail.com \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).