From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Lang <david@lang.hm>
Subject: Re: [FYI] tux3: Core changes
Date: Wed, 20 May 2015 11:01:12 -0700 (PDT)
Message-ID: <alpine.DEB.2.02.1505201058540.25699@nftneq.ynat.uz>
References: <8f886f13-6550-4322-95be-93244ae61045@phunq.net>
 <55545C2F.8040207@phunq.net> <20150519140045.GA16313@quack.suse.cz>
 <555B8C79.4090909@phunq.net>
 <alpine.DEB.2.02.1505191327310.25387@nftneq.ynat.uz>
 <20150520144429.GA17783@quack.suse.cz> <555CB4B6.8050305@phunq.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Cc: Rik van Riel <riel@redhat.com>, Jan Kara <jack@suse.cz>, tux3@tux3.org,
 linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
 OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Daniel Phillips <daniel@phunq.net>
Return-path: <tux3-bounces@phunq.net>
In-Reply-To: <555CB4B6.8050305@phunq.net>
List-Unsubscribe: <http://phunq.net/mailman/options/tux3>,
 <mailto:tux3-request@phunq.net?subject=unsubscribe>
List-Archive: <http://phunq.net/pipermail/tux3/>
List-Post: <mailto:tux3@phunq.net>
List-Help: <mailto:tux3-request@phunq.net?subject=help>
List-Subscribe: <http://phunq.net/mailman/listinfo/tux3>,
 <mailto:tux3-request@phunq.net?subject=subscribe>
Errors-To: tux3-bounces@phunq.net
Sender: "Tux3" <tux3-bounces@phunq.net>
List-Id: linux-fsdevel.vger.kernel.org

On Wed, 20 May 2015, Daniel Phillips wrote:

> On 05/20/2015 07:44 AM, Jan Kara wrote:
>>   Yeah, that's what I meant. If you create a function which manipulates
>> page cache, you better make it work with other functions manipulating page
>> cache. Otherwise it's a landmine waiting to be tripped by some unsuspecting
>> developer. Sure you can document all the conditions under which the
>> function is safe to use but a function that has several paragraphs in front
>> of it explaning when it is safe to use isn't very good API...
>
> Violent agreement, of course. To put it in concrete terms, each of
> the page fork support functions must be examined and determined
> sane. They are:
>
> * cow_replace_page_cache
> * cow_delete_from_page_cache
> * cow_clone_page
> * page_cow_one
> * page_cow_file
>
> Would it be useful to drill down into those, starting from the top
> of the list?

It's a little more than determining that these 5 functions are sane, it's making 
sure that if someone mixes the use of these functions with other existing 
functions that the result is sane.

but it's probably a good starting point to look at each of these five functions 
in detail and consider how they work and could interact badly with other things 
touching the page cache.

David Lang