From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lang Subject: Re: [FYI] tux3: Core changes Date: Wed, 20 May 2015 20:51:46 -0700 (PDT) Message-ID: References: <8f886f13-6550-4322-95be-93244ae61045@phunq.net> <55545C2F.8040207@phunq.net> <20150519140045.GA16313@quack.suse.cz> <555B8C79.4090909@phunq.net> <20150520144429.GA17783@quack.suse.cz> <555CB4B6.8050305@phunq.net> <555CE62C.5030202@redhat.com> <555D0FDF.3070303@phunq.net> <555D500B.4080901@phunq.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Rik van Riel , Jan Kara , linux-fsdevel@vger.kernel.org, tux3@tux3.org, linux-kernel@vger.kernel.org, OGAWA Hirofumi To: Daniel Phillips Return-path: Received: from mail.lang.hm ([64.81.33.126]:56862 "EHLO bifrost.lang.hm" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbEUDwL (ORCPT ); Wed, 20 May 2015 23:52:11 -0400 In-Reply-To: <555D500B.4080901@phunq.net> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 20 May 2015, Daniel Phillips wrote: > On 05/20/2015 03:51 PM, Daniel Phillips wrote: >> On 05/20/2015 12:53 PM, Rik van Riel wrote: >>> How does tux3 prevent a user of find_get_page() from reading from >>> or writing into the pre-COW page, instead of the current page? >> >> Careful control of the dirty bits (we have two of them, one each >> for front and back). That is what pagefork_for_blockdirty is about. > > Ah, and of course it does not matter if a reader is on the > pre-cow page. It would be reading the earlier copy, which might > no longer be the current copy, but it raced with the write so > nobody should be surprised. That is a race even without page fork. how do you prevent it from continuing to interact with the old version of the page and never see updates or have it's changes reflected on the current page? David Lang