From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lang Subject: Re: [FYI] tux3: Core changes Date: Mon, 25 May 2015 23:13:46 -0700 (PDT) Message-ID: References: <8f886f13-6550-4322-95be-93244ae61045@phunq.net> <55545C2F.8040207@phunq.net> <20150519140045.GA16313@quack.suse.cz> <555B8C79.4090909@phunq.net> <20150520144429.GA17783@quack.suse.cz> <555CB4B6.8050305@phunq.net> <555CE62C.5030202@redhat.com> <555D0FDF.3070303@phunq.net> <555D500B.4080901@phunq.net> <13c8bcdf-70e8-43d5-a05f-58ad839dbfd0@phunq.net> <5563F5C8.2040806@redhat.com> <67294911-1776-46b8-916d-0e5642a38725@phunq.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: Rik van Riel , Jan Kara , tux3@tux3.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, OGAWA Hirofumi To: Daniel Phillips Return-path: In-Reply-To: <67294911-1776-46b8-916d-0e5642a38725@phunq.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: tux3-bounces@phunq.net Sender: "Tux3" List-Id: linux-fsdevel.vger.kernel.org On Mon, 25 May 2015, Daniel Phillips wrote: > On Monday, May 25, 2015 11:04:39 PM PDT, David Lang wrote: >> if the page gets modified again, will that cause any issues? what if the >> page gets modified before the copy gets written out, so that there are two >> dirty copies of the page in the process of being written? >> >> David Lang > > How is the page going to get modified again? A forked page isn't > mapped by a pte, so userspace can't modify it by mmap. The forked > page is not in the page cache, so usespace can't modify it by > posix file ops. So the writer would have to be in kernel. Tux3 > knows what it is doing, so it won't modify the page. What kernel > code besides Tux3 will modify the page? I'm assuming that Rik is talking about whatever has the reference to the page via one of the methods that he talked about. David Lang