linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] proc,fcntl: fix ifnullfree.cocci warnings
@ 2020-07-27 10:42 Julia Lawall
  0 siblings, 0 replies; only message in thread
From: Julia Lawall @ 2020-07-27 10:42 UTC (permalink / raw)
  To: Pascal Bouchareine
  Cc: kbuild-all, Alexander Viro, linux-fsdevel, linux-kernel

From: kernel test robot <lkp@intel.com>

NULL check before kfree is not needed.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

CC: Pascal Bouchareine <kalou@tfz.net>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
---

tree:   https://github.com/0day-ci/linux/commits/UPDATE-20200726-101057/Pascal-Bouchareine/proc-fcntl-introduce-F_SET_DESCRIPTION/20200726-053047
head:   56b3babdfa5600eeed065807fd6e80d150b1766b
commit: 56b3babdfa5600eeed065807fd6e80d150b1766b [1/1] proc,fcntl: introduce F_SET_DESCRIPTION
:::::: branch date: 27 hours ago
:::::: commit date: 27 hours ago

Please take the patch only if it's a positive warning. Thanks!

 file_table.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/fs/file_table.c
+++ b/fs/file_table.c
@@ -272,8 +272,7 @@ static void __fput(struct file *file)
 	eventpoll_release(file);
 	locks_remove_file(file);

-	if (file->f_description)
-		kfree(file->f_description);
+	kfree(file->f_description);

 	ima_file_free(file);
 	if (unlikely(file->f_flags & FASYNC)) {

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2020-07-27 10:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-27 10:42 [PATCH] proc,fcntl: fix ifnullfree.cocci warnings Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).