From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94A1FC4360C for ; Mon, 19 Apr 2021 13:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69EC361077 for ; Mon, 19 Apr 2021 13:55:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240998AbhDSN4K (ORCPT ); Mon, 19 Apr 2021 09:56:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43480 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240043AbhDSNz7 (ORCPT ); Mon, 19 Apr 2021 09:55:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1618840529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WxdqbfoBJXaYxfD6rImyDUvIjZiF5Q3ecjdpEO3HnrU=; b=ALrFn8rBvCOneEIRJpiS+PUwY/EVnEEWr0OIAoD+DCYCCj7hvuuIzWTlpmKaz2m9DIsPD0 MYdL7jBbGD74pfE1ZYP+ugvcXh5qqA/sbfiePiZJFhQY/rffc0FtImyhspJNzU0umDAqEH ma6F419qUXU9blHD0uCguRNSfmQsfok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-302-OjBtjruXOaaknhPs7HO74A-1; Mon, 19 Apr 2021 09:55:26 -0400 X-MC-Unique: OjBtjruXOaaknhPs7HO74A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C60D687A83C; Mon, 19 Apr 2021 13:55:24 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FB8E5D9CA; Mon, 19 Apr 2021 13:55:18 +0000 (UTC) Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id 13JDtH4F018187; Mon, 19 Apr 2021 09:55:17 -0400 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id 13JDtHQu018179; Mon, 19 Apr 2021 09:55:17 -0400 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Mon, 19 Apr 2021 09:55:17 -0400 (EDT) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: Damien Le Moal cc: "dm-devel@redhat.com" , Mike Snitzer , "linux-block@vger.kernel.org" , Jens Axboe , "linux-nvme@lists.infradead.org" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "Martin K . Petersen" , "linux-fsdevel@vger.kernel.org" , Shinichiro Kawasaki , Johannes Thumshirn , Milan Broz Subject: Re: [dm-devel] [PATCH v2 0/3] Fix dm-crypt zoned block device support In-Reply-To: Message-ID: References: <20210417023323.852530-1-damien.lemoal@wdc.com> User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 19 Apr 2021, Damien Le Moal wrote: > > I would say that it is incompatible with all dm targets - even the linear > > target is changing the sector number and so it may redirect the write > > outside of the range specified in dm-table and cause corruption. > > DM remapping of BIO sectors is zone compatible because target entries must be > zone aligned. In the case of zone append, the BIO sector always point to the > start sector of the target zone. DM sector remapping will remap that to another > zone start as all zones are the same size. No issue here. We extensively use > dm-linear for various test environment to reduce the size of the device tested > (to speed up tests). I am confident there are no problems there. > > > Instead of complicating device mapper with imperfect support, I would just > > disable REQ_OP_ZONE_APPEND on device mapper at all. > > That was my initial approach, but for dm-crypt only since other targets that > support zoned devices are fine. However, this breaks zoned block device > requirement that zone append be supported so that users are presented with a > uniform interface for different devices. So while simple to do, disabling zone > append is far from ideal. So, we could enable it for the linear target and disable for all other targets? I talked with Milan about it and he doesn't want to add more bloat to the crypt target. I agree with him. Mikulas