From: James Morris <jmorris@namei.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
syzbot <syzbot+9369930ca44f29e60e2d@syzkaller.appspotmail.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk,
linux-security-module@vger.kernel.org
Subject: Re: KASAN: null-ptr-deref Read in xattr_getsecurity
Date: Wed, 11 Apr 2018 09:20:45 +1000 (AEST) [thread overview]
Message-ID: <alpine.LRH.2.21.1804110920220.9111@namei.org> (raw)
In-Reply-To: <87o9irw2ad.fsf@xmission.com>
On Tue, 10 Apr 2018, Eric W. Biederman wrote:
> Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:
>
> > From 904d07a6eb014f3df0c5a1ebfcfd4323276a9a76 Mon Sep 17 00:00:00 2001
> > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> > Date: Tue, 10 Apr 2018 15:15:16 +0900
> > Subject: [PATCH] commoncap: Handle memory allocation failure.
> >
> > syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1],
> > for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when
> > memory allocation failed. Return -ENOMEM if memory allocation failed.
> >
> > [1] https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>
> Tetsuo I can pick this up, or do you have preferred path for getting
> this change merged?
>
It can go via my tree if needed, but otherwise:
Acked-by: James Morris <james.morris@microsoft.com>
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2018-04-10 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 8:36 KASAN: null-ptr-deref Read in xattr_getsecurity syzbot
2018-04-10 10:13 ` Tetsuo Handa
2018-04-10 14:42 ` Eric W. Biederman
2018-04-10 14:48 ` Serge E. Hallyn
2018-04-10 21:00 ` Tetsuo Handa
2018-04-25 11:01 ` Tetsuo Handa
2018-04-10 23:20 ` James Morris [this message]
2018-04-10 14:45 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1804110920220.9111@namei.org \
--to=jmorris@namei.org \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=serge@hallyn.com \
--cc=syzbot+9369930ca44f29e60e2d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).