From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from namei.org ([65.99.196.166]:56476 "EHLO namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754370AbeDJXUx (ORCPT ); Tue, 10 Apr 2018 19:20:53 -0400 Date: Wed, 11 Apr 2018 09:20:45 +1000 (AEST) From: James Morris To: "Eric W. Biederman" cc: Tetsuo Handa , syzbot , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk, linux-security-module@vger.kernel.org Subject: Re: KASAN: null-ptr-deref Read in xattr_getsecurity In-Reply-To: <87o9irw2ad.fsf@xmission.com> Message-ID: References: <0000000000008d2e0d05697a693d@google.com> <9d192497-8b1e-ca8d-0ed8-b3324ee1e361@I-love.SAKURA.ne.jp> <87o9irw2ad.fsf@xmission.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 10 Apr 2018, Eric W. Biederman wrote: > Tetsuo Handa writes: > > > From 904d07a6eb014f3df0c5a1ebfcfd4323276a9a76 Mon Sep 17 00:00:00 2001 > > From: Tetsuo Handa > > Date: Tue, 10 Apr 2018 15:15:16 +0900 > > Subject: [PATCH] commoncap: Handle memory allocation failure. > > > > syzbot is reporting NULL pointer dereference at xattr_getsecurity() [1], > > for cap_inode_getsecurity() is returning sizeof(struct vfs_cap_data) when > > memory allocation failed. Return -ENOMEM if memory allocation failed. > > > > [1] https://syzkaller.appspot.com/bug?id=a55ba438506fe68649a5f50d2d82d56b365e0107 > > Acked-by: "Eric W. Biederman" > > Tetsuo I can pick this up, or do you have preferred path for getting > this change merged? > It can go via my tree if needed, but otherwise: Acked-by: James Morris -- James Morris