From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 559ECC32750 for ; Tue, 13 Aug 2019 22:42:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3370620644 for ; Tue, 13 Aug 2019 22:42:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727398AbfHMWmW (ORCPT ); Tue, 13 Aug 2019 18:42:22 -0400 Received: from linux.microsoft.com ([13.77.154.182]:40528 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726878AbfHMWmW (ORCPT ); Tue, 13 Aug 2019 18:42:22 -0400 Received: by linux.microsoft.com (Postfix, from userid 1029) id CD4FE20B7187; Tue, 13 Aug 2019 11:49:40 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com CD4FE20B7187 Received: from localhost (localhost [127.0.0.1]) by linux.microsoft.com (Postfix) with ESMTP id 039FE3005457; Tue, 13 Aug 2019 11:49:40 -0700 (PDT) Date: Tue, 13 Aug 2019 11:49:39 -0700 (PDT) From: Jaskaran Singh Khurana X-X-Sender: jaskarankhurana@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net To: Mike Snitzer cc: gmazyland@gmail.com, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-fsdevel@vger.kernel.org, scottsh@microsoft.com, ebiggers@google.com, jmorris@namei.org, dm-devel@redhat.com, mpatocka@redhat.com, agk@redhat.com Subject: Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation. In-Reply-To: <20190625182004.GA32075@redhat.com> Message-ID: References: <20190619191048.20365-1-jaskarankhurana@linux.microsoft.com> <20190619191048.20365-2-jaskarankhurana@linux.microsoft.com> <20190625182004.GA32075@redhat.com> User-Agent: Alpine 2.21 (LRH 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Hello Mike, On Tue, 25 Jun 2019, Mike Snitzer wrote: > On Wed, Jun 19 2019 at 3:10pm -0400, > Jaskaran Khurana wrote: > >> The verification is to support cases where the roothash is not secured by >> Trusted Boot, UEFI Secureboot or similar technologies. >> One of the use cases for this is for dm-verity volumes mounted after boot, >> the root hash provided during the creation of the dm-verity volume has to >> be secure and thus in-kernel validation implemented here will be used >> before we trust the root hash and allow the block device to be created. >> >> The signature being provided for verification must verify the root hash and >> must be trusted by the builtin keyring for verification to succeed. >> >> The hash is added as a key of type "user" and the description is passed to >> the kernel so it can look it up and use it for verification. >> >> Kernel commandline parameter will indicate whether to check (only if >> specified) or force (for all dm verity volumes) roothash signature >> verification. >> >> Kernel commandline: dm_verity.verify_sig=1 or 2 for check/force root hash >> signature validation respectively. >> >> Signed-off-by: Jaskaran Khurana > > Milan and/or others: could you please provide review and if you're OK > with this patch respond accordingly? > The v7 of this patch was Reviewed and Tested by Milan Broz. Could you tell me when this will be merged/next steps, if required I can post the patches again. > Thanks, > Mike > Regards, Jaskaran