Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: akpm@linux-foundation.org, dxu@dxuuu.xyz, chris@chrisdown.name,
	adilger@dilger.ca, gregkh@linuxfoundation.org, tj@kernel.org,
	viro@zeniv.linux.org.uk, hughd@google.com, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] vfs/xattr: mm/shmem: kernfs: release simple xattr entry in a right way
Date: Fri, 3 Jul 2020 23:03:52 -0700 (PDT)
Message-ID: <alpine.LSU.2.11.2007032300270.1238@eggly.anvils> (raw)
In-Reply-To: <20200704051608.15043-1-cgxu519@mykernel.net>

On Sat, 4 Jul 2020, Chengguang Xu wrote:

> After commit fdc85222d58e ("kernfs: kvmalloc xattr value
> instead of kmalloc"), simple xattr entry is allocated with
> kvmalloc() instead of kmalloc(), so we should release it
> with kvfree() instead of kfree().
> 
> Cc: stable@vger.kernel.org # v5.7
> Cc: Daniel Xu <dxu@dxuuu.xyz>
> Cc: Chris Down <chris@chrisdown.name>
> Cc: Andreas Dilger <adilger@dilger.ca>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Hugh Dickins <hughd@google.com>
> Fixes: fdc85222d58e ("kernfs: kvmalloc xattr value instead of kmalloc")
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>

Good catch, thank you:
Acked-by: Hugh Dickins <hughd@google.com>

> ---
> v1->v2:
> - Fix freeing issue in simple_xattrs_free().
> - Change patch subject.
> 
>  include/linux/xattr.h | 3 ++-
>  mm/shmem.c            | 2 +-
>  2 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/xattr.h b/include/linux/xattr.h
> index 47eaa34f8761..c5afaf8ca7a2 100644
> --- a/include/linux/xattr.h
> +++ b/include/linux/xattr.h
> @@ -15,6 +15,7 @@
>  #include <linux/slab.h>
>  #include <linux/types.h>
>  #include <linux/spinlock.h>
> +#include <linux/mm.h>
>  #include <uapi/linux/xattr.h>
>  
>  struct inode;
> @@ -94,7 +95,7 @@ static inline void simple_xattrs_free(struct simple_xattrs *xattrs)
>  
>  	list_for_each_entry_safe(xattr, node, &xattrs->head, list) {
>  		kfree(xattr->name);
> -		kfree(xattr);
> +		kvfree(xattr);
>  	}
>  }
>  
> diff --git a/mm/shmem.c b/mm/shmem.c
> index a0dbe62f8042..b2abca3f7f33 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -3178,7 +3178,7 @@ static int shmem_initxattrs(struct inode *inode,
>  		new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len,
>  					  GFP_KERNEL);
>  		if (!new_xattr->name) {
> -			kfree(new_xattr);
> +			kvfree(new_xattr);
>  			return -ENOMEM;
>  		}
>  
> -- 
> 2.20.1
> 
> 
> 
> 

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04  5:16 Chengguang Xu
2020-07-04  6:03 ` Hugh Dickins [this message]
2020-07-06 14:58 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.11.2007032300270.1238@eggly.anvils \
    --to=hughd@google.com \
    --cc=adilger@dilger.ca \
    --cc=akpm@linux-foundation.org \
    --cc=cgxu519@mykernel.net \
    --cc=chris@chrisdown.name \
    --cc=dxu@dxuuu.xyz \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tj@kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git