From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77BA9C49ED6 for ; Mon, 9 Sep 2019 19:33:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5558321A4A for ; Mon, 9 Sep 2019 19:33:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405683AbfIITdL (ORCPT ); Mon, 9 Sep 2019 15:33:11 -0400 Received: from ale.deltatee.com ([207.54.116.67]:41288 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731005AbfIITdK (ORCPT ); Mon, 9 Sep 2019 15:33:10 -0400 Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.89) (envelope-from ) id 1i7PPJ-0001h7-5A; Mon, 09 Sep 2019 13:33:02 -0600 To: Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org Cc: Chaitanya Kulkarni , Stephen Bates , Jens Axboe , Keith Busch , Max Gurtovoy , Christoph Hellwig References: <20190828215429.4572-1-logang@deltatee.com> <20190828215429.4572-14-logang@deltatee.com> <92d61426-65a2-827c-936b-55f12f3d6afb@grimberg.me> <7954e8a4-6026-2210-7192-94a4e483facf@grimberg.me> From: Logan Gunthorpe Message-ID: Date: Mon, 9 Sep 2019 13:32:56 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <7954e8a4-6026-2210-7192-94a4e483facf@grimberg.me> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: hch@lst.de, maxg@mellanox.com, kbusch@kernel.org, axboe@fb.com, sbates@raithlin.com, Chaitanya.Kulkarni@wdc.com, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, sagi@grimberg.me X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH v8 13/13] nvmet-passthru: support block accounting X-SA-Exim-Version: 4.2.1 (built Tue, 02 Aug 2016 21:08:31 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019-09-09 1:26 p.m., Sagi Grimberg wrote: > >>>> Support block disk accounting by setting the RQF_IO_STAT flag >>>> and gendisk in the request. >>>> >>>> After this change, IO counts will be reflected correctly in >>>> /proc/diskstats for drives being used by passthru. >>>> >>>> Signed-off-by: Logan Gunthorpe >>>> --- >>>> drivers/nvme/target/io-cmd-passthru.c | 5 ++++- >>>> 1 file changed, 4 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/nvme/target/io-cmd-passthru.c b/drivers/nvme/target/io-cmd-passthru.c >>>> index 7557927a3451..63f12750a80d 100644 >>>> --- a/drivers/nvme/target/io-cmd-passthru.c >>>> +++ b/drivers/nvme/target/io-cmd-passthru.c >>>> @@ -410,6 +410,9 @@ static struct request *nvmet_passthru_blk_make_request(struct nvmet_req *req, >>>> if (unlikely(IS_ERR(rq))) >>>> return rq; >>>> >>>> + if (blk_queue_io_stat(q) && cmd->common.opcode != nvme_cmd_flush) >>>> + rq->rq_flags |= RQF_IO_STAT; >> >> Thanks for the review! >> >>> Does flush has data bytes in the request? Why the special casing? >> >> Well it was special cased in the vanilla blk account flow... But I think >> it's required to be special cased so the IO and in_flight counts don't >> count flushes (as they do not for regular block device traffic). > > I think that the accounting exclude I/O that is yielded from the flush > sequence. Don't think its relevant here... What? Per blk_account_io_done(), RQF_FLUSH_SEQ will not be set by us for passthru commands and I don't think it's appropriate to do so. Thus, if we set RQF_IO_STAT for passthru flush commands, they will be counted which we do not want. Logan