From: Andreas Gruenbacher <andreas.gruenbacher@gmail.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: [RFC v3 03/45] nfsd: Checking for acl support does not require fetching any acls
Date: Fri, 24 Apr 2015 13:04:00 +0200 [thread overview]
Message-ID: <b3a09e6f1071ea01de64aa3071cb533e79fb4b18.1429868795.git.agruenba@redhat.com> (raw)
In-Reply-To: <cover.1429868795.git.agruenba@redhat.com>
In-Reply-To: <cover.1429868795.git.agruenba@redhat.com>
Whether or not a file system supports acls can be determined with
IS_POSIXACL(inode) and does not require trying to fetch any acls; the code for
computing the supported_attrs and aclsupport attributes can be simplified.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/nfsd/nfs4xdr.c | 25 ++++++++++---------------
1 file changed, 10 insertions(+), 15 deletions(-)
diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
index 5fb7e78..e2d602d 100644
--- a/fs/nfsd/nfs4xdr.c
+++ b/fs/nfsd/nfs4xdr.c
@@ -2227,7 +2227,6 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp,
u32 rdattr_err = 0;
__be32 status;
int err;
- int aclsupport = 0;
struct nfs4_acl *acl = NULL;
void *context = NULL;
int contextlen;
@@ -2274,19 +2273,15 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp,
goto out;
fhp = tempfh;
}
- if (bmval0 & (FATTR4_WORD0_ACL | FATTR4_WORD0_ACLSUPPORT
- | FATTR4_WORD0_SUPPORTED_ATTRS)) {
+ if (bmval0 & FATTR4_WORD0_ACL) {
err = nfsd4_get_nfs4_acl(rqstp, dentry, &acl);
- aclsupport = (err == 0);
- if (bmval0 & FATTR4_WORD0_ACL) {
- if (err == -EOPNOTSUPP)
- bmval0 &= ~FATTR4_WORD0_ACL;
- else if (err == -EINVAL) {
- status = nfserr_attrnotsupp;
- goto out;
- } else if (err != 0)
- goto out_nfserr;
- }
+ if (err == -EOPNOTSUPP)
+ bmval0 &= ~FATTR4_WORD0_ACL;
+ else if (err == -EINVAL) {
+ status = nfserr_attrnotsupp;
+ goto out;
+ } else if (err != 0)
+ goto out_nfserr;
}
#ifdef CONFIG_NFSD_V4_SECURITY_LABEL
@@ -2338,7 +2333,7 @@ nfsd4_encode_fattr(struct xdr_stream *xdr, struct svc_fh *fhp,
u32 word1 = nfsd_suppattrs1(minorversion);
u32 word2 = nfsd_suppattrs2(minorversion);
- if (!aclsupport)
+ if (!IS_POSIXACL(dentry->d_inode))
word0 &= ~FATTR4_WORD0_ACL;
if (!contextsupport)
word2 &= ~FATTR4_WORD2_SECURITY_LABEL;
@@ -2486,7 +2481,7 @@ out_acl:
p = xdr_reserve_space(xdr, 4);
if (!p)
goto out_resource;
- *p++ = cpu_to_be32(aclsupport ?
+ *p++ = cpu_to_be32(IS_POSIXACL(dentry->d_inode) ?
ACL4_SUPPORT_ALLOW_ACL|ACL4_SUPPORT_DENY_ACL : 0);
}
if (bmval0 & FATTR4_WORD0_CANSETTIME) {
--
2.1.0
next prev parent reply other threads:[~2015-04-24 11:04 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 11:03 [RFC v3 00/45] Richacls Andreas Gruenbacher
2015-04-24 11:03 ` [RFC v3 01/45] vfs: Minor documentation fix Andreas Gruenbacher
2015-04-24 11:03 ` [RFC v3 02/45] uapi: Remove kernel internal declaration Andreas Gruenbacher
2015-04-24 11:04 ` Andreas Gruenbacher [this message]
2015-04-24 11:04 ` [RFC v3 04/45] vfs: Shrink struct posix_acl Andreas Gruenbacher
2015-04-25 7:56 ` Rasmus Villemoes
2015-04-27 10:27 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 05/45] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 06/45] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 07/45] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD " Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 09/45] vfs: Add permission flags for setting file attributes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 10/45] richacl: In-memory representation and helper functions Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 11/45] richacl: Permission mapping functions Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 12/45] richacl: Compute maximum file masks from an acl Andreas Gruenbacher
2015-05-12 21:44 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 15/45] vfs: Cache base_acl objects in inodes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 16/45] vfs: Cache richacl in struct inode Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 17/45] richacl: Create-time inheritance Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 18/45] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls Andreas Gruenbacher
2015-05-14 19:28 ` J. Bruce Fields
[not found] ` <20150514192806.GG12861-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-05-15 20:04 ` J. Bruce Fields
[not found] ` <5e9ee3b123b3d648487cd18dc906b6a2cd23085b.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-15 20:51 ` J. Bruce Fields
2015-05-27 9:24 ` Andreas Grünbacher
2015-05-27 15:06 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 20/45] richacl: Automatic Inheritance Andreas Gruenbacher
[not found] ` <28e2cd75064ff56bad897b6f69356f4fb15b8128.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-13 18:01 ` Frank Filz
2015-05-13 20:22 ` Andreas Grünbacher
2015-05-13 20:28 ` Jeremy Allison
2015-05-13 20:47 ` Andreas Grünbacher
2015-05-13 20:55 ` Jeremy Allison
2015-05-13 21:15 ` Andreas Grünbacher
[not found] ` <CAHpGcMLBb+s7iSv9SN1eRX-46VU_wnbGX1nXrNkuaYVp8v0jYw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-13 20:38 ` Frank Filz
2015-05-13 21:05 ` Andreas Grünbacher
2015-05-13 22:56 ` Frank Filz
2015-05-13 23:52 ` Andreas Grünbacher
2015-05-14 15:09 ` J. Bruce Fields
[not found] ` <20150514150925.GE12861-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-05-18 20:39 ` Andreas Grünbacher
[not found] ` <CAHpGcMLK+=Sd+5xS5bsq+7FffiKQAH_t53yAMpiukeVh1JB6Mw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-18 20:43 ` J. Bruce Fields
[not found] ` <cover.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-24 11:04 ` [RFC v3 08/45] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 13/45] richacl: Update the file masks in chmod() Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 14/45] richacl: Permission check algorithm Andreas Gruenbacher
2015-05-22 21:08 ` J. Bruce Fields
2015-05-27 11:25 ` Andreas Grünbacher
2015-05-27 15:05 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 21/45] richacl: xattr mapping functions Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 22/45] vfs: Add richacl permission checking Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 25/45] richacl: acl editing helper functions Andreas Gruenbacher
[not found] ` <a74bc8fdb5d8ee5bdd5defad9729d17211266079.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-15 21:33 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 39/45] nfs3: Return posix acl encode errors Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 23/45] ext4: Add richacl support Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 24/45] ext4: Add richacl feature flag Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 26/45] richacl: Move everyone@ aces down the acl Andreas Gruenbacher
2015-05-18 21:20 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 27/45] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 28/45] richacl: Isolate the owner and group classes Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 29/45] richacl: Apply the file masks to a richacl Andreas Gruenbacher
[not found] ` <35b73e9515f2395c8595cbbf4ea7b92216e5e2a0.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-26 21:56 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 30/45] richacl: Create richacl from mode values Andreas Gruenbacher
[not found] ` <b435787dd651572f42984f9dec2a68cbf38bc7bf.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-28 19:24 ` J. Bruce Fields
2015-05-28 19:25 ` J. Bruce Fields
[not found] ` <20150528192553.GB31663-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-05-28 19:58 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 31/45] richacl: Create acl with masks applied in richacl_from_mode() Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 32/45] nfsd: Remove dead declarations Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 33/45] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher
[not found] ` <4f0168389120bf67cf69ce4ac7bb8ce878aa0f5d.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-28 19:52 ` J. Bruce Fields
[not found] ` <20150528195205.GC31663-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-05-28 20:28 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 34/45] nfsd: Use richacls as internal acl representation Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 35/45] nfsd: Add richacl support Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 36/45] NFSv4: Fix GETATTR bitmap verification Andreas Gruenbacher
[not found] ` <8d601ee8babe5239b7926542c713c58502b15e35.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-28 20:33 ` J. Bruce Fields
2015-05-28 21:15 ` Andreas Grünbacher
[not found] ` <20150528203332.GD31663-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2015-05-28 20:50 ` Trond Myklebust
[not found] ` <CAHQdGtTe9RfxxGU+UzxnT8A1BmhtPQaOB=g6wXpvmHTu6Ho=Jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 21:05 ` Andreas Grünbacher
[not found] ` <CAHpGcM+=ydzFDeTc4_1F9dYbtJ+D_mGVLKZOYkvvRjT7ZHd_xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 21:40 ` Trond Myklebust
[not found] ` <CAHQdGtQKRokdRRuGmU-qD3fxOUE8cYrtb=sNcYenVT8M8XAmYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 21:55 ` Trond Myklebust
[not found] ` <CAHQdGtRaq93Rk1ZNn7tqBPJVWhWwUGS7k1XzdC3etfna4kLtDg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 22:09 ` Andreas Grünbacher
[not found] ` <CAHpGcMLQGc4HUZEDRKAv2yaH7wwSBBO_jrMA6+=AQ6hb=WrNUg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-28 22:24 ` Trond Myklebust
2015-05-28 22:28 ` Andreas Grünbacher
2015-05-28 21:28 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 37/45] nfs/sunrpc: No more encode and decode function pointer casting Andreas Gruenbacher
2015-05-28 23:11 ` Trond Myklebust
2015-05-28 23:40 ` Andreas Grünbacher
[not found] ` <CAHpGcMKn1khdNTk=MFS7vFgLCHmxX2fVTJanertXT+Zj_BnAKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-29 0:37 ` Trond Myklebust
[not found] ` <CAHQdGtRKLnMbB6Z5w7MCnONujHH2uBnx4VUrTL1GGfWTNwurRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-05-29 15:30 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 38/45] nfs/sunrpc: Return status code from encode functions Andreas Gruenbacher
[not found] ` <9c755df47acdef7f6a1d0195af888dafb7d3e7bf.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-28 23:39 ` Trond Myklebust
2015-04-24 11:04 ` [RFC v3 40/45] nfs: Remove unused xdr page offsets in getacl/setacl arguments Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 41/45] rpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher
[not found] ` <4bf77d045d2bd3494c695229cd0505b7002cc9a2.1429868795.git.agruenba-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-05-28 23:24 ` Trond Myklebust
2015-05-29 15:46 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 42/45] nfs: Add richacl support Andreas Gruenbacher
2015-05-28 23:06 ` Trond Myklebust
2015-05-28 23:29 ` Andreas Grünbacher
2015-05-29 13:15 ` Trond Myklebust
2015-05-29 15:00 ` Andreas Grünbacher
2015-05-29 15:24 ` Trond Myklebust
2015-05-29 15:45 ` Andreas Grünbacher
2015-05-29 15:54 ` Trond Myklebust
2015-05-29 15:54 ` Frank Filz
2016-06-23 16:37 ` Weston Andros Adamson
2016-06-23 17:15 ` Frank Filz
2016-07-15 8:00 ` Andreas Grünbacher
2015-04-24 11:04 ` [RFC v3 43/45] uapi/nfs: Add NFSv4.1 ACL definitions Andreas Gruenbacher
2015-05-29 14:57 ` J. Bruce Fields
2015-04-24 11:04 ` [RFC v3 44/45] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher
2015-04-24 11:04 ` [RFC v3 45/45] nfs: " Andreas Gruenbacher
2015-05-23 15:50 ` [RFC v3 00/45] Richacls Jeremy Allison
2015-05-23 15:56 ` Andreas Grünbacher
2015-06-25 20:03 ` Stefan (metze) Metzmacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3a09e6f1071ea01de64aa3071cb533e79fb4b18.1429868795.git.agruenba@redhat.com \
--to=andreas.gruenbacher@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).