From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB2DC48BC2 for ; Mon, 21 Jun 2021 15:57:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E2CF061261 for ; Mon, 21 Jun 2021 15:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230363AbhFUQAF (ORCPT ); Mon, 21 Jun 2021 12:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229719AbhFUQAE (ORCPT ); Mon, 21 Jun 2021 12:00:04 -0400 Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A319DC061574 for ; Mon, 21 Jun 2021 08:57:50 -0700 (PDT) Received: by mail-io1-xd30.google.com with SMTP id p66so16379085iod.8 for ; Mon, 21 Jun 2021 08:57:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jVYdu/JHdD3DwhMqrGzbw0N2BmX7zM9L4IBZN/tXq4k=; b=lJmqJkiPNEyFyPAbp4D6y1VBZuqm5pleBw65Z/IGXbZACmJQN2qTHhchdJ1nCrRhAn 69j4SK0Apv1hr2shIUyGbQTIr/9PBNRkSO4rf/hJ2UJJVHOFcJsElRJUAeUWFIoomHDA EFtDPQHf3FBomAyrBXS0vuIz6JXwK2ykLos79JpxwiDD4IjZjFjJ+uEGw2t6MZLZ5zJZ 2hzPjNp53k9UOltyJQ0nzOg8wt6I+q7W3NXaU+qAjFHZO88wvHZKlHr1+53YrAgY9K5A 91NvYc4A4Lb2wC6fWojD8xd76ZOmM1ctcMDN2rpjbHDYovTDXzbbuUGwxilierulMgVS E19w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jVYdu/JHdD3DwhMqrGzbw0N2BmX7zM9L4IBZN/tXq4k=; b=GRyEbdgPoDH8cyGAF+bgBUl7auyftfLccu2mKE2VbBOsWF3r92w+Bl9kA5FzunUsEa WQisVxXuuRybITtHMP01MbSuzAq+wNU4GBrjGrOsTHBOnym63VOOVfN0sKXBx174cK+q VbFTVQW+5TPBM/vktdkd1Z1Vwk6Lc7AD7fx219XqKCaGlf6BSTFGZzIdNb6hPd6Q9bVJ 1aCzaWvS/0EB3Zy9ibQYDVPg4/aMx/JswZWIdChUwAhJCUCRGSAD4lDsLu5maRdVWZyp H0TAHFyMdrv8e7aBge/gnrztRE0viVdvf0TJ1DHMmY6VUnX/S4udVlDwK7o2ElitZs+G 1YDg== X-Gm-Message-State: AOAM531y1kO1hyvMYslxDkGSTcR/0rp3GJnvOH3Zl1uZHim+7oVRkTcV RjQTB2c9jc1wGFHxG/JRQjHjSg== X-Google-Smtp-Source: ABdhPJxvN6WY08A8+Wl4gxpRvSZQltvzkxQ1N5q3tgRtCRHk0hc1Ehwp44qxs0Em0S+iy45zRwlRig== X-Received: by 2002:a5d:9f07:: with SMTP id q7mr19701533iot.169.1624291070033; Mon, 21 Jun 2021 08:57:50 -0700 (PDT) Received: from [192.168.1.30] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id l11sm6343017ilo.77.2021.06.21.08.57.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Jun 2021 08:57:49 -0700 (PDT) Subject: Re: [PATCH v5 00/10] io_uring: add mkdir, [sym]linkat and mknodat support To: Dmitry Kadashev , Alexander Viro , Christian Brauner Cc: Pavel Begunkov , linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org References: <20210603051836.2614535-1-dkadashev@gmail.com> From: Jens Axboe Message-ID: Date: Mon, 21 Jun 2021 09:57:48 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210603051836.2614535-1-dkadashev@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 6/2/21 11:18 PM, Dmitry Kadashev wrote: > This started out as an attempt to add mkdirat support to io_uring which > is heavily based on renameat() / unlinkat() support. > > During the review process more operations were added (linkat, symlinkat, > mknodat) mainly to keep things uniform internally (in namei.c), and > with things changed in namei.c adding support for these operations to > io_uring is trivial, so that was done too. See > https://lore.kernel.org/io-uring/20210514145259.wtl4xcsp52woi6ab@wittgenstein/ > > The first patch is preparation with no functional changes, makes > do_mkdirat accept struct filename pointer rather than the user string. > > The second one leverages that to implement mkdirat in io_uring. > > 3-6 just convert other similar do_* functions in namei.c to accept > struct filename, for uniformity with do_mkdirat, do_renameat and > do_unlinkat. No functional changes there. > > 7 changes do_* helpers in namei.c to return ints rather than some of > them returning ints and some longs. > > 8-10 add symlinkat, linkat and mknodat support to io_uring > (correspondingly). > > Based on for-5.14/io_uring. Can you send in the liburing tests as well? -- Jens Axboe