From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E7E9C3A59C for ; Fri, 16 Aug 2019 07:25:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BDFC20644 for ; Fri, 16 Aug 2019 07:25:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726637AbfHPHZw (ORCPT ); Fri, 16 Aug 2019 03:25:52 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:34278 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726575AbfHPHZv (ORCPT ); Fri, 16 Aug 2019 03:25:51 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 88D86B213B1AD625CCD0; Fri, 16 Aug 2019 15:25:46 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 16 Aug 2019 15:25:36 +0800 Subject: Re: [PATCH] staging: erofs: use common file type conversion To: Gao Xiang , Greg Kroah-Hartman , , CC: LKML , , "Linus Torvalds" , Chao Yu , Miao Xie , , Fang Wei References: <20190816071142.8633-1-gaoxiang25@huawei.com> From: Chao Yu Message-ID: Date: Fri, 16 Aug 2019 15:25:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190816071142.8633-1-gaoxiang25@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2019/8/16 15:11, Gao Xiang wrote: > Deduplicate the EROFS file type conversion implementation and > remove EROFS_FT_* definitions since it's the same as defined > by POSIX, let's follow ext2 as Linus pointed out [1] > commit e10892189428 ("ext2: use common file type conversion"). > > [1] https://lore.kernel.org/r/CAHk-=wiUs+b=iVKM3mVooXgVk7cmmC67KTmnAuL0cd_cMMVAKw@mail.gmail.com/ > > Reported-by: Linus Torvalds > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,