From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:40520 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752491AbeEONpY (ORCPT ); Tue, 15 May 2018 09:45:24 -0400 Subject: Re: [RFC PATCH v2 2/2] locking/percpu-rwsem: Mark rwsem as non-spinnable in percpu_rwsem_release() To: Amir Goldstein Cc: Ingo Molnar , Peter Zijlstra , Thomas Gleixner , linux-kernel , linux-fsdevel , Davidlohr Bueso , "Theodore Y. Ts'o" , Oleg Nesterov , Jan Kara References: <1526326267-22501-1-git-send-email-longman@redhat.com> <1526326267-22501-3-git-send-email-longman@redhat.com> From: Waiman Long Message-ID: Date: Tue, 15 May 2018 09:45:22 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 05/15/2018 01:42 AM, Amir Goldstein wrote: > On Mon, May 14, 2018 at 10:31 PM, Waiman Long wrote: >> The percpu_rwsem_release() is called when the ownership of the embedded >> rwsem is to be transferred to another task. The new owner, however, may >> take a while to get the ownership of the lock via percpu_rwsem_acquire(). >> During that period, the rwsem is now marked as writer-owned with no >> optimistic spinning. >> > Waiman, > > Thanks for the fix. I will test it soon. > > For this commit message I suggest that you add parts of the reproducer > found here: > https://marc.info/?l=linux-fsdevel&m=152622016219975&w=2 > > Thanks, > Amir. Sure. I will add that to the commit log. Cheers, Longman