From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21C8DC11D00 for ; Fri, 21 Feb 2020 00:21:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ECC4724653 for ; Fri, 21 Feb 2020 00:21:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="I6fAixvG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729529AbgBUAVX (ORCPT ); Thu, 20 Feb 2020 19:21:23 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:33250 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729392AbgBUAVX (ORCPT ); Thu, 20 Feb 2020 19:21:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=tMJ8YKxTeBtxTcT9+8gwag/FsvtT3wSn7stN9kvfG0Q=; b=I6fAixvGMEOmvfzzpJEepAfJtm PXVdq7yCLQEEvy3t4ujzGyV7hIW+tgNWOV8C5gsgeQYhP6ptOwGo++BOf6tv10ZObHBITktO81YPa 4jTb5lEt5DXYFa/oiYiSp7rLSDtYv9RCg2hyZx+zX+bQ/SrQKlYio37lgRDJw1YECZxMGJfkoLMwR CN/nFFlNnR7HtjwlPFeDw5VT4YPCJkAPkoD9d4K90iqtIkPIfypmhBbxTdEdhNu3K0GaPha8Nmgqp yuh3hYYGgfpmN2VKO1HvdUWu2GBjyqBPghv3XIiekadWeA8GpLbHW3OafvDVigtMmp/mfiK4hAPQO vAbEVGdQ==; Received: from [2601:1c0:6280:3f0::19c2] by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1j4w4H-0003FS-Sz; Fri, 21 Feb 2020 00:21:21 +0000 Subject: Re: [PATCH v2 6/7] misc: bcm-vk: add Broadcom VK driver To: Scott Branden , Luis Chamberlain , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann Cc: "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , Desmond Yan , James Hu References: <20200220004825.23372-1-scott.branden@broadcom.com> <20200220004825.23372-7-scott.branden@broadcom.com> <827a4520-95ce-5264-90d9-ed730e5918e6@infradead.org> <22c48aaf-21e2-56ab-3f40-e497a69cd936@broadcom.com> From: Randy Dunlap Message-ID: Date: Thu, 20 Feb 2020 16:21:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <22c48aaf-21e2-56ab-3f40-e497a69cd936@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2/20/20 4:06 PM, Scott Branden wrote: > Hi Randy, > > On 2020-02-19 5:04 p.m., Randy Dunlap wrote: >> Hi, >> >> On 2/19/20 4:48 PM, Scott Branden wrote: >>> diff --git a/drivers/misc/bcm-vk/Kconfig b/drivers/misc/bcm-vk/Kconfig >>> new file mode 100644 >>> index 000000000000..c75dfb89a38d >>> --- /dev/null >>> +++ b/drivers/misc/bcm-vk/Kconfig >>> @@ -0,0 +1,42 @@ >>> +# SPDX-License-Identifier: GPL-2.0-only >>> +# >>> +# Broadcom VK device >>> +# >>> +config BCM_VK >>> +    tristate "Support for Broadcom VK Accelerators" >>> +    depends on PCI_MSI >>> +    default m >> Need to justify default m. Normally we don't add drivers as enabled unless >> they are required for basic (boot) operation. > Will remove default m as not needed to boot.  Interesting other offload engines misc/ocxl/Kconfig and misc/cxl/Kconfig have default m. Thanks. Uh, yes, that is interesting. They both depend on PPC_POWERNV, which I know nothing about. >>> +    help >>> +      Select this option to enable support for Broadcom >>> +      VK Accelerators.  VK is used for performing >>> +      specific video offload processing.  This driver enables >>> +      userspace programs to access these accelerators via /dev/bcm-vk.N >>> +      devices. >>> + >>> +      If unsure, say N. -- ~Randy