From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C232EC56201 for ; Wed, 25 Nov 2020 07:20:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 606FB208B8 for ; Wed, 25 Nov 2020 07:20:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="lJ5FVu75" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727132AbgKYHUK (ORCPT ); Wed, 25 Nov 2020 02:20:10 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:58180 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbgKYHUK (ORCPT ); Wed, 25 Nov 2020 02:20:10 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AP78dtC035974; Wed, 25 Nov 2020 07:19:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=P11wfyw6N9I5O2TUURcfkhBRfDzRLjlWVpteChZnBqc=; b=lJ5FVu75iAH8IaqJy/9aoubXb/XpzMh8MaskZWTzO+Ou84u4bKDkyDLD1AjufjXJFh1C FYIOz5mDlu6QPAlxW75qDoQfRlmOXXsaQUngkXQQvuF9Gv/QM9MfzpggMkVobHallEha frSfUAXkLZPaG05gFtytUmIlYhdP4JuAB/VYTSeKDwuJQDjYRjv+ZTWl4cQHv9yhja5r YsIKRXKZLxa0AvrMc0HtJFT+g17pYZjvzCYT4J79pqi0iXYhHLuxZ0Bb28yIAe4M/XyT ipHjJf88cP55aWBh6XoZt7SzMbakU60xw0+JXybAu3V+dU6XQksRsHM+OyIpChhkVIbM Xw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 3514q8k4rf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 25 Nov 2020 07:19:57 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0AP7Fhk5004041; Wed, 25 Nov 2020 07:17:56 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 34yx8ktt43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Nov 2020 07:17:56 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0AP7HqeN024591; Wed, 25 Nov 2020 07:17:53 GMT Received: from [192.168.1.102] (/39.109.186.25) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 24 Nov 2020 23:17:52 -0800 Subject: Re: [PATCH v10 12/41] btrfs: implement zoned chunk allocator To: Naohiro Aota Cc: linux-btrfs@vger.kernel.org, dsterba@suse.com, hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" References: <9cec3af1-4f2c-c94c-1506-07db2c66cc90@oracle.com> <20201125015740.conrettvmrgwebus@naota.dhcp.fujisawa.hgst.com> From: Anand Jain Message-ID: Date: Wed, 25 Nov 2020 15:17:42 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201125015740.conrettvmrgwebus@naota.dhcp.fujisawa.hgst.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9815 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011250041 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9815 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1015 impostorscore=0 mlxscore=0 suspectscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 malwarescore=0 adultscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011250041 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 25/11/20 9:57 am, Naohiro Aota wrote: > On Tue, Nov 24, 2020 at 07:36:18PM +0800, Anand Jain wrote: >> On 10/11/20 7:26 pm, Naohiro Aota wrote: >>> This commit implements a zoned chunk/dev_extent allocator. The zoned >>> allocator aligns the device extents to zone boundaries, so that a zone >>> reset affects only the device extent and does not change the state of >>> blocks in the neighbor device extents. >>> >>> Also, it checks that a region allocation is not overlapping any of the >>> super block zones, and ensures the region is empty. >>> >>> Signed-off-by: Naohiro Aota >> >> Looks good. >> >> Chunks and stripes are aligned to the zone_size. I guess zone_size won't >> change after the block device has been formatted with it? For testing, >> what if the device image is dumped onto another zoned device with a >> different zone_size? > > Zone size is a drive characteristic, so it never change on the same device. > > Dump/restore on another device with a different zone_size should be banned, > because we cannot ensure device extents are aligned to zone boundaries. Fair enough. Do we have any checks to fail such mount? Sorry if I have missed it somewhere in the patch? Thanks.