From: "Jan H. Schönherr" <jschoenh@amazon.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Matthew Wilcox <mawilcox@microsoft.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] dax: Release PMD lock even when there is no PMD support in DAX
Date: Thu, 18 Jan 2018 15:35:32 +0100 [thread overview]
Message-ID: <c5a4f205-2d88-72de-86fe-4a43ec7afb34@amazon.de> (raw)
In-Reply-To: <62c74e2b-1342-8a8c-f1a8-7daa285e6a0f@amazon.de>
On 01/18/2018 03:27 PM, Jan H. Schönherr wrote:
> It would still skip the unlock, in case pmdp is !=NULL (and locked) after follow_pte_pmd().
> So it wouldn't address, what I intended to address with the patch.
Small correction: we'd take the "else" branch, which would do some stuff it's not supposed to do
when follow_pte_pmd() returns with pmdp!=NULL. And we'd actually do a unlock, but thinking it's
a PTE, not a PMD.
So, defensive-wise, may point still stands, that we're not correctly handling an unexpectedly
returned PMD entry.
Regards
Jan
next prev parent reply other threads:[~2018-01-18 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 13:38 [PATCH] dax: Release PMD lock even when there is no PMD support in DAX Jan H. Schönherr
2018-01-18 14:07 ` Matthew Wilcox
2018-01-18 14:22 ` Matthew Wilcox
2018-01-18 14:27 ` Jan H. Schönherr
2018-01-18 14:35 ` Jan H. Schönherr [this message]
2018-01-18 14:22 ` Jan H. Schönherr
2018-01-18 16:20 ` Ross Zwisler
2018-01-25 16:34 ` Ross Zwisler
2018-01-25 21:29 ` Jan H. Schönherr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5a4f205-2d88-72de-86fe-4a43ec7afb34@amazon.de \
--to=jschoenh@amazon.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).