From: Jens Axboe <axboe@kernel.dk>
To: Johannes Thumshirn <jthumshirn@suse.de>, Jan Kara <jack@suse.cz>
Cc: Hannes Reinecke <hare@suse.com>, Hannes Reinecke <hare@suse.de>,
Jan Kara <jack@suse.com>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block_dev: fix crash on chained bios with O_DIRECT
Date: Wed, 20 Mar 2019 13:57:42 -0600 [thread overview]
Message-ID: <c5c3312f-9670-01f7-1303-e05414dc96f0@kernel.dk> (raw)
In-Reply-To: <94293d71-fab4-43cd-3d83-243995218907@suse.de>
On 3/20/19 7:19 AM, Johannes Thumshirn wrote:
> On 20/03/2019 12:47, Jan Kara wrote:
>> On Wed 20-03-19 09:53:10, Johannes Thumshirn wrote:
>>> On 20/03/2019 09:51, Hannes Reinecke wrote:
>>>> Yeah, should work, too.
>>>> But we should be calling bio_uninit() for all bios.
>>>
>>> Yup, probably.
>>>
>>>> Will you be sending an updated patch?
>>>
>>> Let's wait what other's thing first.
>>
>> FWIW I'm OK with either solution. Yours seems a bit more future-proof so I
>> like it a bit more.
>
> FWIW Bit 13 for the Flag doesn't work, need to find a free one before
> doing a proper submission.
Yeah, you're going to overlap and crash... We really should have a build
bug on for that.
We don't have any free ones. I've got a patch in io_uring-next that
uses the last one.
That said, I do greatly prefer your approach to solving the issue.
--
Jens Axboe
next prev parent reply other threads:[~2019-03-20 19:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 8:12 [PATCH] block_dev: fix crash on chained bios with O_DIRECT Hannes Reinecke
2019-03-20 8:45 ` Johannes Thumshirn
2019-03-20 8:51 ` Hannes Reinecke
2019-03-20 8:53 ` Johannes Thumshirn
2019-03-20 11:47 ` Jan Kara
2019-03-20 13:19 ` Johannes Thumshirn
2019-03-20 19:57 ` Jens Axboe [this message]
2019-03-21 8:28 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5c3312f-9670-01f7-1303-e05414dc96f0@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).