From: Randy Dunlap <rdunlap@infradead.org>
To: akpm@linux-foundation.org, broonie@kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, linux-next@vger.kernel.org, mhocko@suse.cz,
mm-commits@vger.kernel.org, sfr@canb.auug.org.au,
Patrick Daly <pdaly@codeaurora.org>
Subject: Re: mmotm 2021-02-08-15-44 uploaded (mm-cma-print-region-name-on-failure.patch)
Date: Mon, 8 Feb 2021 20:03:09 -0800 [thread overview]
Message-ID: <c85a7dba-2f2a-c518-ab9d-26a0c934adda@infradead.org> (raw)
In-Reply-To: <20210208234508.iCc6kmL1z%akpm@linux-foundation.org>
On 2/8/21 3:45 PM, akpm@linux-foundation.org wrote:
> The mm-of-the-moment snapshot 2021-02-08-15-44 has been uploaded to
>
> https://www.ozlabs.org/~akpm/mmotm/
>
> mmotm-readme.txt says
>
> README for mm-of-the-moment:
>
> https://www.ozlabs.org/~akpm/mmotm/
>
> This is a snapshot of my -mm patch queue. Uploaded at random hopefully
> more than once a week.
>
> You will need quilt to apply these patches to the latest Linus release (5.x
> or 5.x-rcY). The series file is in broken-out.tar.gz and is duplicated in
> https://ozlabs.org/~akpm/mmotm/series
>
> The file broken-out.tar.gz contains two datestamp files: .DATE and
> .DATE-yyyy-mm-dd-hh-mm-ss. Both contain the string yyyy-mm-dd-hh-mm-ss,
> followed by the base kernel version against which this patch series is to
> be applied.
>
> This tree is partially included in linux-next. To see which patches are
> included in linux-next, consult the `series' file. Only the patches
> within the #NEXT_PATCHES_START/#NEXT_PATCHES_END markers are included in
> linux-next.
mm-cma-print-region-name-on-failure.patch:
This causes a printk format warning on i386 (these used to be readable):
In file included from ../include/linux/printk.h:7:0,
from ../include/linux/kernel.h:16,
from ../include/asm-generic/bug.h:20,
from ../arch/x86/include/asm/bug.h:93,
from ../include/linux/bug.h:5,
from ../include/linux/mmdebug.h:5,
from ../include/linux/mm.h:9,
from ../include/linux/memblock.h:13,
from ../mm/cma.c:24:
../mm/cma.c: In function ‘cma_alloc’:
../include/linux/kern_levels.h:5:18: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 4 has type ‘long unsigned int’ [-Wformat=]
#define KERN_SOH "\001" /* ASCII Start Of Header */
^
../include/linux/kern_levels.h:11:18: note: in expansion of macro ‘KERN_SOH’
#define KERN_ERR KERN_SOH "3" /* error conditions */
^~~~~~~~
../include/linux/printk.h:343:9: note: in expansion of macro ‘KERN_ERR’
printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
^~~~~~~~
../mm/cma.c:503:3: note: in expansion of macro ‘pr_err’
pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
^~~~~~
../mm/cma.c:503:45: note: format string is defined here
pr_err("%s: %s: alloc failed, req-size: %zu pages, ret: %d\n",
~~^
%lu
because the type of count is not the same as the type of cma->count.
Furthermore, are you sure that cma->count is the same value as count?
I'm not.
(also s/convienience/convenience/ in the patch description)
thanks.
--
~Randy
next prev parent reply other threads:[~2021-02-09 4:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 23:45 mmotm 2021-02-08-15-44 uploaded akpm
2021-02-09 4:03 ` Randy Dunlap [this message]
2021-02-09 14:26 ` mmotm 2021-02-08-15-44 uploaded (mm-cma-print-region-name-on-failure.patch) Georgi Djakov
2021-02-09 4:20 ` mmotm 2021-02-08-15-44 uploaded (drivers/media/i2c/rdacm2*.c) Randy Dunlap
2021-02-09 5:02 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c85a7dba-2f2a-c518-ab9d-26a0c934adda@infradead.org \
--to=rdunlap@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=broonie@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-next@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=mm-commits@vger.kernel.org \
--cc=pdaly@codeaurora.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).