From: Paul Wise <email@example.com> To: Alexander Viro <firstname.lastname@example.org>, email@example.com, linux-kernel <firstname.lastname@example.org> Cc: Jakub Wilk <email@example.com> Subject: PROBLEM: Linux kernel.core_pattern with pipes does argument splitting after template expansion Date: Tue, 19 Mar 2019 14:06:27 +0800 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) [-- Attachment #1: Type: text/plain, Size: 1611 bytes --] The Linux kernel.core_pattern support for core dump handlers using the pipe syntax does argument splitting after template expansion. At minimum this bug could cause truncated values for the executable name. This also means that the argument parsing for core dump handlers is slightly more complicated because they have to deal with the fact that an attacker that can control the executable name via %E and %e could pass additional arguments, including command-line options, to the handler. Usually this is easy to deal with by merging the remaining arguments after an options termination indicator but it is very unlikely that core dump handler implementers are aware of the issue. Theoretically hostnames with %h could also be split up but in practice they do not appear to be allowed to contain spaces. Steps to reproduce: $ cat foo #!/bin/sh printf "%s~" "$@" >> /var/log/core echo >> /var/log/core $ chmod a+rx foo $ sudo sysctl kernel.core_pattern="|`pwd`/foo %E" kernel.core_pattern = |/home/pabs/foo %E $ cp /bin/sleep 'sleep with spaces' $ ./sleep\ with\ spaces 55555 &  16041 $ kill -SEGV %1 + Segmentation fault (core dumped) ./sleep\ with\ spaces 55555 Incorrect results: $ cat /var/log/core !home!pabs!sleep~with~spaces~ Correct results: $ cat /var/log/core !home!pabs!sleep with spaces~ This was originally reported by Jakub Wilk <email@example.com>: <firstname.lastname@example.org> https://bugs.debian.org/924398 -- bye, pabs https://bonedaddy.net/pabs3/ [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next reply other threads:[~2019-03-19 6:15 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-19 6:06 Paul Wise [this message] 2019-05-20 9:01 ` [PATCH] coredump: Split pipe command whitespace before expanding template Paul Wise 2019-05-20 15:14 ` kbuild test robot 2019-05-21 0:37 ` Paul Wise 2019-05-28 5:11 ` [PATCH v3] " Paul Wise 2019-06-06 13:44 ` Neil Horman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: PROBLEM: Linux kernel.core_pattern with pipes does argument splitting after template expansion' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).