linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Piotr Jaroszynski <pjaroszynski@nvidia.com>
To: Christoph Hellwig <hch@lst.de>, <p.jaroszynski@gmail.com>
Cc: Michal Hocko <mhocko@suse.com>, <linux-fsdevel@vger.kernel.org>,
	<linux-mm@kvack.org>
Subject: Re: [PATCH] iomap: get/put the page in iomap_page_create/release()
Date: Thu, 15 Nov 2018 10:44:51 -0800	[thread overview]
Message-ID: <c9f77d5d-bace-a0e4-777c-51ab2ed6107e@nvidia.com> (raw)
In-Reply-To: <20181115093045.GA14847@lst.de>

On 11/15/18 1:30 AM, Christoph Hellwig wrote:
>> Fixes: 82cb14175e7d ("xfs: add support for sub-pagesize writeback
>>                       without buffer_heads")
> 
> I've never seen line breaks in Fixes tags, is this really a valid format?

Probably not, fixed in v2.

> 
>> +	/*
>> +	 * At least migrate_page_move_mapping() assumes that pages with private
>> +	 * data have their count elevated by 1.
>> +	 */
> 
> I'd drop the "At least".

Fixed in v2.

> 
> Otherwise this looks fine to me:
> 
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> 

Thanks!

Thanks,
Piotr

  reply	other threads:[~2018-11-15 18:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  0:30 [PATCH] iomap: get/put the page in iomap_page_create/release() p.jaroszynski
2018-11-15  9:30 ` Christoph Hellwig
2018-11-15 18:44   ` Piotr Jaroszynski [this message]
2019-01-21 15:17 Christoph Hellwig
2019-01-31 23:28 ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9f77d5d-bace-a0e4-777c-51ab2ed6107e@nvidia.com \
    --to=pjaroszynski@nvidia.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=p.jaroszynski@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).