From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F30E0C433E0 for ; Mon, 18 May 2020 10:39:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D13AC207F5 for ; Mon, 18 May 2020 10:39:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=themaw.net header.i=@themaw.net header.b="2YM8ZP+h"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="SppxqMLq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726279AbgERKjk (ORCPT ); Mon, 18 May 2020 06:39:40 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:33151 "EHLO wout3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgERKjj (ORCPT ); Mon, 18 May 2020 06:39:39 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id CE936A0E; Mon, 18 May 2020 06:39:38 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 18 May 2020 06:39:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm3; bh= a8qFxPgNXDbutBfdJc1ON1dfUT2X5u0TBiN9wBESi40=; b=2YM8ZP+h1aGr4UcI 2I1q4GLRacLJsxwjPYfMBGUwNsyVQ1b3mzHFkVed6z2DkgdPFy8qUOTAe5ZlK6TD Uc4gmxz80NMt0puVliNpTzmrJWBcaAKa6U5NUBoLKBGf/U2DU1k+RodfBn1Hcxr3 +pKUaZCB+LqBRhTLui343Tl8lI0thG8PpRQUSzSVX5WgYxvH+JF0HwLZw4Ajimp0 6AN9uQol+Ah/hr7RGNV0NEl6QTr6Q54KbUPQqHGF1KEU1YHxSk+0y2NUo42+v0Ja oc9krOnCsS5bzX6k9U1thfUajk7DANRcN2RHBkPYY5JrR2QNm7dOqiDfnKxXd7ng gLfQSQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=a8qFxPgNXDbutBfdJc1ON1dfUT2X5u0TBiN9wBESi 40=; b=SppxqMLqw/wTD/Ug/Vw8ALf5EYHj+Wg4vxNbD04++zeI5Cu7+F2CSAX3+ t9XW6WmFK4RMeNAMPBTsazz4KbcNRvU2bEf56i3EMlKnqHvld+Y4LYP17kQGrQHy G/gaw1A22Xf8F33DOIc1fetR8ieIXk0cXSAMw7KB80TL8aZSJPeUeQR8F0AX3ne9 uBclTcf2PP60rkxfwG0Yzp8SzvOE3sYXijJkku0X1kAsJI/81q6d8PinFbJT2xP6 Tw0THWWKWs7aWtwjh395zbSzFjjHxlFe+6O2Dl6Scl6GmgJzYiXuujItGm8CDSbi I7jhEhke+cUB3IcLwo7x6G1JysRQg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedruddthedgfedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkffuhffvffgjfhgtfggggfesthejredttderjeenucfhrhhomhepkfgrnhcu mfgvnhhtuceorhgrvhgvnhesthhhvghmrgifrdhnvghtqeenucggtffrrghtthgvrhhnpe effeettedvgeduvdevfeevfeettdffudduheeuiefhueevgfevheffledugefgjeenucfk phepuddukedrvddtkedrudekiedrudenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehrrghvvghnsehthhgvmhgrfidrnhgvth X-ME-Proxy: Received: from mickey.themaw.net (unknown [118.208.186.1]) by mail.messagingengine.com (Postfix) with ESMTPA id 06A4030663F6; Mon, 18 May 2020 06:39:34 -0400 (EDT) Message-ID: Subject: Re: [RFC PATCH v3 0/9] Suppress negative dentry From: Ian Kent To: Amir Goldstein Cc: Chengguang Xu , Miklos Szeredi , Al Viro , linux-fsdevel , overlayfs Date: Mon, 18 May 2020 18:39:31 +0800 In-Reply-To: References: <20200515072047.31454-1-cgxu519@mykernel.net> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 2020-05-18 at 18:26 +0800, Ian Kent wrote: > > Now d_splice_alias() is pretty complicated but, if passed a NULL > dentry it amounts to calling __d_add(dentry, NULL) which produces > a negative hashed dentry, a decision made by ext4 ->lookup() (and > I must say typical of the very few ways such dentries get into > the dcache). Oh, rather that's a NULL inode not dentry. Ian