From: Chao Yu <yuchao0@huawei.com>
To: Matthew Wilcox <willy@infradead.org>, sunqiuyang <sunqiuyang@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>, <miaoxie@huawei.com>,
<fangwei1@huawei.com>, <stummala@codeaurora.org>
Subject: Re: [PATCH v2 1/1] f2fs: ioctl for removing a range from F2FS
Date: Mon, 20 May 2019 20:05:35 +0800 [thread overview]
Message-ID: <ce0b747e-6e3d-6285-7f20-f4ecd6c4df6c@huawei.com> (raw)
In-Reply-To: <20190517025628.GF31704@bombadil.infradead.org>
On 2019/5/17 10:56, Matthew Wilcox wrote:
> On Fri, May 17, 2019 at 10:16:47AM +0800, sunqiuyang wrote:
>> +++ b/fs/f2fs/f2fs.h
>> @@ -423,6 +423,8 @@ static inline bool __has_cursum_space(struct f2fs_journal *journal,
>> #define F2FS_IOC_SET_PIN_FILE _IOW(F2FS_IOCTL_MAGIC, 13, __u32)
>> #define F2FS_IOC_GET_PIN_FILE _IOR(F2FS_IOCTL_MAGIC, 14, __u32)
>> #define F2FS_IOC_PRECACHE_EXTENTS _IO(F2FS_IOCTL_MAGIC, 15)
>> +#define F2FS_IOC_SHRINK_RESIZE _IOW(F2FS_IOCTL_MAGIC, 16, \
>> + struct f2fs_resize_param)
>
> Why not match ext4?
>
> fs/ext4/ext4.h:#define EXT4_IOC_RESIZE_FS _IOW('f', 16, __u64)
Agreed, Qiuyang, could you consider to implement this interface as ext4's, in
addition, changing parameter from shrunk bytes to new block count of fs?
F2FS_IOC_RESIZE_FS _IOW('f', 16, __u64)
if (copy_from_user(&block_count, (__u64 __user *)arg, sizeof(__u64)))
Thanks,
>
> .
>
prev parent reply other threads:[~2019-05-20 12:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 2:16 [PATCH v2 1/1] f2fs: ioctl for removing a range from F2FS sunqiuyang
2019-05-17 2:56 ` Matthew Wilcox
2019-05-20 12:05 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce0b747e-6e3d-6285-7f20-f4ecd6c4df6c@huawei.com \
--to=yuchao0@huawei.com \
--cc=fangwei1@huawei.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaoxie@huawei.com \
--cc=stummala@codeaurora.org \
--cc=sunqiuyang@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).