From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH 1/2] mm: introduce put_user_page(), placeholder version To: kbuild test robot , CC: , Matthew Wilcox , Michal Hocko , Christopher Lameter , Jason Gunthorpe , Dan Williams , Jan Kara , Al Viro , , LKML , linux-rdma , References: <20180709080554.21931-2-jhubbard@nvidia.com> <201807091833.xMr1iYDX%fengguang.wu@intel.com> From: John Hubbard Message-ID: Date: Mon, 9 Jul 2018 11:48:44 -0700 MIME-Version: 1.0 In-Reply-To: <201807091833.xMr1iYDX%fengguang.wu@intel.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On 07/09/2018 03:08 AM, kbuild test robot wrote: > Hi John, > > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on linus/master] ... > >>> drivers/platform//goldfish/goldfish_pipe.c:334:13: error: conflicting types for 'release_user_pages' > static void release_user_pages(struct page **pages, int pages_count, > ^~~~~~~~~~~~~~~~~~ Yes. Patches #1 and #2 need to be combined here. I'll do that in the next version, which will probably include several of the easier put_user_page() conversions, as well. thanks, -- John Hubbard NVIDIA