linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Omar Sandoval <osandov@osandov.com>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Eric Biederman <ebiederm@xmission.com>,
	James Morse <james.morse@arm.com>,
	Bhupesh Sharma <bhsharma@redhat.com>,
	kernel-team@fb.com
Subject: [PATCH v2 0/7] /proc/kcore improvements
Date: Thu, 12 Jul 2018 17:09:32 -0700	[thread overview]
Message-ID: <cover.1531440458.git.osandov@fb.com> (raw)

From: Omar Sandoval <osandov@fb.com>

Hi,

This series makes a few improvements to /proc/kcore. Patches 1 and 2 are
prep patches. Patch 3 is a fix/cleanup. Patch 4 is another prep patch.
Patches 5 and 6 are optimizations to ->read(). Patch 7 adds vmcoreinfo
to /proc/kcore (apparently I'm not the only one who wants this, see
https://www.spinics.net/lists/arm-kernel/msg665103.html).

I tested that the crash utility still works with this applied, and
readelf is happy with it, as well.

Andrew, since this didn't get any traction on the fsdevel side, and
you're already carrying James' patch, could you take this through -mm?

Thanks!

Changes from v1:

- Rebased onto v4.18-rc4 + James' patch
  (https://patchwork.kernel.org/patch/10519739/) in the mm tree
- Fix spurious sparse warning (see the report and response in
  https://patchwork.kernel.org/patch/10512431/)

Omar Sandoval (7):
  proc/kcore: don't grab lock for kclist_add()
  proc/kcore: replace kclist_lock rwlock with rwsem
  proc/kcore: fix memory hotplug vs multiple opens race
  proc/kcore: hold lock during read
  proc/kcore: clean up ELF header generation
  proc/kcore: optimize multiple page reads
  proc/kcore: add vmcoreinfo note to /proc/kcore

 fs/proc/Kconfig            |   1 +
 fs/proc/kcore.c            | 536 +++++++++++++++++--------------------
 include/linux/crash_core.h |   2 +
 kernel/crash_core.c        |   4 +-
 4 files changed, 251 insertions(+), 292 deletions(-)

-- 
2.18.0

             reply	other threads:[~2018-07-13  0:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13  0:09 Omar Sandoval [this message]
2018-07-13  0:09 ` [PATCH v2 1/7] proc/kcore: don't grab lock for kclist_add() Omar Sandoval
2018-07-18  2:35   ` Andrew Morton
2018-07-18  3:19     ` Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 2/7] proc/kcore: replace kclist_lock rwlock with rwsem Omar Sandoval
2018-07-18  2:38   ` Andrew Morton
2018-07-18  3:24     ` Omar Sandoval
2018-07-18  3:27       ` Andrew Morton
2018-07-18  3:36         ` Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 3/7] proc/kcore: fix memory hotplug vs multiple opens race Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 4/7] proc/kcore: hold lock during read Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 5/7] proc/kcore: clean up ELF header generation Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 6/7] proc/kcore: optimize multiple page reads Omar Sandoval
2018-07-13  0:09 ` [PATCH v2 7/7] proc/kcore: add vmcoreinfo note to /proc/kcore Omar Sandoval
2018-07-18  2:44   ` Andrew Morton
2018-07-18  3:27     ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1531440458.git.osandov@fb.com \
    --to=osandov@osandov.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=bhsharma@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=james.morse@arm.com \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).