From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0E16C47247 for ; Thu, 30 Apr 2020 18:47:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EFBD2073E for ; Thu, 30 Apr 2020 18:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="CS7iZoWG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726503AbgD3SrI (ORCPT ); Thu, 30 Apr 2020 14:47:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726272AbgD3SrH (ORCPT ); Thu, 30 Apr 2020 14:47:07 -0400 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9017EC035495 for ; Thu, 30 Apr 2020 11:47:06 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id h69so3214163pgc.8 for ; Thu, 30 Apr 2020 11:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ABdRQgBI25yIrNvDESTtqmXMNbdBPdhiiSh6GEOf12k=; b=CS7iZoWGBiAeaHIhT3vGdnnpVYg3KGf4JUbPH7vg1jP7Wyh+f14SEPpo8mHgtDYzYS SK+Ou1SVqV8PrNAL1wKoKB/zIHibqlrG9vCmbenfxeQGs80iOXx0WUPMZxCAyvuL7pKy 0WxCAVumF9a+kz7dxFn4dhJM0FsFTmbHE8WV4r+2upnZVkwdAq+r6iEJ71izlXReGZKv 7bw3pkXgwQUseVNIH2JCQohcFdJnyPm4Y6aTAUY/mZPtSY/ZLuxt4epw+TSBrrUTnEkc 2atVBpwYmaW6IbsQGugx0yso0lsOSZlxWi5UsMZCKRbfJQYkaA9EfcGxJNm8gdRgjOJz durA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ABdRQgBI25yIrNvDESTtqmXMNbdBPdhiiSh6GEOf12k=; b=IrKMMU8OPtr2FP6WhaiqPO2R6cwReTfUNhtdbZOnbLNjBSCoLaUItHeepjE2hLJTiM iiEY6k9cATpGaprS9Ub4fcuV0NLSWKYSezUEhFRckU0fT8Z3cUPP21+WC3CQgE/UtZY8 BCyDGbJdJXdcOXHB+BNAU+khuk37BuNiXUGf+fLsetzvWUslxNhvCtRgLtUWbaVUdLoa izFkP0VjMc5SQ65fNECsSwPZKqWY3T94Nem73ZcJdAF9+I7HYdV4fCfk9aSiCFAwMRKX 2C8id0erM/WDhsO9sidron7Vs432dSblUygJssGlkSSj+ZMxCUjZ48aNnvKSrmJz0XMq gbIQ== X-Gm-Message-State: AGi0PuZgc18lvXz69S5u0VQtPrL1yrEEld4UKAorTD6W1pXzCpGv2brP eSRBRk5xf7QbHywbfKkdvh52Ng== X-Google-Smtp-Source: APiQypK50Mb5vUZOYLMzB7jL/Aw7RXfUYPGr8cTLOc5I+VuurshaMp5y0AtUjuRe4ZiNEEcvfpCTcw== X-Received: by 2002:a62:6246:: with SMTP id w67mr119360pfb.326.1588272425985; Thu, 30 Apr 2020 11:47:05 -0700 (PDT) Received: from [192.168.1.188] ([66.219.217.145]) by smtp.gmail.com with ESMTPSA id y26sm413214pfn.185.2020.04.30.11.47.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 11:47:05 -0700 (PDT) Subject: Re: [PATCH] pipe: read/write_iter() handler should check for IOCB_NOWAIT To: Matthew Wilcox Cc: Alexander Viro , linux-fsdevel , "linux-kernel@vger.kernel.org" References: <273d8294-2508-a4c2-f96e-a6a394f94166@kernel.dk> <20200430175856.GX29705@bombadil.infradead.org> From: Jens Axboe Message-ID: Date: Thu, 30 Apr 2020 12:47:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200430175856.GX29705@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 4/30/20 11:58 AM, Matthew Wilcox wrote: > On Thu, Apr 30, 2020 at 10:24:46AM -0600, Jens Axboe wrote: >> Pipe read/write only checks for the file O_NONBLOCK flag, but we should >> also check for IOCB_NOWAIT for whether or not we should handle this read >> or write in a non-blocking fashion. If we don't, then we will block on >> data or space for iocbs that explicitly asked for non-blocking >> operation. This messes up callers that explicitly ask for non-blocking >> operations. >> >> Signed-off-by: Jens Axboe > > Wouldn't this be better? Yeah, that's probably a better idea. Care to send a "proper" patch? -- Jens Axboe