From: Waiman Long <longman@redhat.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Takashi Iwai <tiwai@suse.de>, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH v8 2/5] ipc: IPCMNI limit check for semmni
Date: Fri, 29 Jun 2018 15:26:23 +0800 [thread overview]
Message-ID: <d0596d73-1130-3ee5-a8ee-b8a9e8989d45@redhat.com> (raw)
In-Reply-To: <20180628223906.GB331@wotan.suse.de>
On 06/29/2018 06:39 AM, Luis R. Rodriguez wrote:
> On Mon, Jun 18, 2018 at 06:28:15PM +0800, Waiman Long wrote:
>> For SysV semaphores, the semmni value is the last part of the 4-element
>> sem number array. To make semmni behave in a similar way to msgmni and
>> shmmni, we can't directly use the _minmax handler. Instead, a special
>> sem specific handler is added to check the last argument to make sure
>> that it is limited to the [0, IPCMNI] range. An error will be returned
>> if this is not the case.
> Sorry my time has run out, and will be on vacation until July 10th. If
> this can wait until then then great, otherwise hopefully Kees can take
> a look. It would be wonderful to get Eric's review on this as well.
>
> Luis
Thanks for the review. I will try to get other reviewer to chime in.
Kees and Eric, do you have comments on this patchset?
Cheers,
Longman
next prev parent reply other threads:[~2018-06-29 7:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-18 10:28 [PATCH v8 0/5] ipc: IPCMNI limit check for *mni & increase that limit Waiman Long
2018-06-18 10:28 ` [PATCH v8 1/5] ipc: IPCMNI limit check for msgmni and shmmni Waiman Long
2018-06-28 3:16 ` Luis R. Rodriguez
2018-08-17 16:51 ` Davidlohr Bueso
2018-06-18 10:28 ` [PATCH v8 2/5] ipc: IPCMNI limit check for semmni Waiman Long
2018-06-28 22:39 ` Luis R. Rodriguez
2018-06-29 7:26 ` Waiman Long [this message]
2018-08-17 16:53 ` Davidlohr Bueso
2018-06-18 10:28 ` [PATCH v8 3/5] ipc: Allow boot time extension of IPCMNI from 32k to 2M Waiman Long
2018-08-17 16:45 ` Davidlohr Bueso
2018-08-18 1:15 ` Waiman Long
2018-10-02 16:32 ` Manfred Spraul
2018-10-02 17:43 ` Waiman Long
2018-06-18 10:28 ` [PATCH v8 4/5] ipc: Conserve sequence numbers in extended IPCMNI mode Waiman Long
2018-06-18 10:28 ` [PATCH v8 5/5] ipc: Add a new ipcmni_compat sysctl to fall back to old behavior Waiman Long
2018-06-18 11:36 ` kbuild test robot
2018-06-18 14:27 ` kbuild test robot
2018-08-17 16:50 ` [PATCH v8 0/5] ipc: IPCMNI limit check for *mni & increase that limit Davidlohr Bueso
2018-09-06 22:24 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0596d73-1130-3ee5-a8ee-b8a9e8989d45@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dbueso@suse.de \
--cc=ebiederm@xmission.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=tiwai@suse.de \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).