From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:1675 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751712AbeF2H01 (ORCPT ); Fri, 29 Jun 2018 03:26:27 -0400 Subject: Re: [PATCH v8 2/5] ipc: IPCMNI limit check for semmni To: "Luis R. Rodriguez" Cc: Kees Cook , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Al Viro , Matthew Wilcox , "Eric W. Biederman" , Takashi Iwai , Davidlohr Bueso References: <1529317698-16575-1-git-send-email-longman@redhat.com> <1529317698-16575-3-git-send-email-longman@redhat.com> <20180628223906.GB331@wotan.suse.de> From: Waiman Long Message-ID: Date: Fri, 29 Jun 2018 15:26:23 +0800 MIME-Version: 1.0 In-Reply-To: <20180628223906.GB331@wotan.suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 06/29/2018 06:39 AM, Luis R. Rodriguez wrote: > On Mon, Jun 18, 2018 at 06:28:15PM +0800, Waiman Long wrote: >> For SysV semaphores, the semmni value is the last part of the 4-element >> sem number array. To make semmni behave in a similar way to msgmni and >> shmmni, we can't directly use the _minmax handler. Instead, a special >> sem specific handler is added to check the last argument to make sure >> that it is limited to the [0, IPCMNI] range. An error will be returned >> if this is not the case. > Sorry my time has run out, and will be on vacation until July 10th. If > this can wait until then then great, otherwise hopefully Kees can take > a look. It would be wonderful to get Eric's review on this as well. > > Luis Thanks for the review. I will try to get other reviewer to chime in. Kees and Eric, do you have comments on this patchset? Cheers, Longman