From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28FCAC04A6B for ; Fri, 10 May 2019 22:13:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DFFE82184B for ; Fri, 10 May 2019 22:13:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hoVMY294" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728342AbfEJWNp (ORCPT ); Fri, 10 May 2019 18:13:45 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36076 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727943AbfEJWNp (ORCPT ); Fri, 10 May 2019 18:13:45 -0400 Received: by mail-pf1-f196.google.com with SMTP id v80so3921423pfa.3; Fri, 10 May 2019 15:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=k2Aq/0pFsKkTwsuWTj1NhOQs1y2YwfgcFH7dMaJeBgA=; b=hoVMY294/X8wHW4bG3jFoSfzQVD5twfR7+jf5iBN6t4WX5nMMkoV4x879lcOfkp7xi TvUWJxB+suod2heR5o4T6vWv23l2pqMuzCrv4fEdXGEgqK0X90ApJ5cY0Z79X1LBVTJ/ JqAVR2W0MAM1Q8gqs9jklHAQ+rVW+OSHi96IhpzOe0hO2navqrCpJJoFLlWQfmM2o2/y mj6yh88N0y9hd0Aeu164ynxYT3f21Q3iAe4vxyRctXJmLdad5zASs/mlmCcZUo8WuXrA i8XcwIhi8rj5T63Vm+hg8lWmTDSyCji2r5FZFPzu1HJT2UKqowWPtNmhX2OLFeAFY7Nu 39Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k2Aq/0pFsKkTwsuWTj1NhOQs1y2YwfgcFH7dMaJeBgA=; b=mdb6TKvoP04GPtZYviaJwWT0BcAcMArWNjSTVNmzvnsOWbAhV2JZzzhV1KMrI+A8s+ G3Q/8s7HupHDc2Ba3kIlRFp1gtkqVEkoQql5SwwHheC9I3LsZmfjTbzgQzDdL1Baqe7E GIFH4Ua6KkYBSYAnPy/ThU+nrRjfB059/E5WgAivvYXv9Jf0G3QeZpfzS6OvDmM0FuK4 xowQ7elje8Q4228tOwcqL1QPVtBuDazBopL9SSsGIxdlD7qA/dHqIYWKOXVUwlUFld2K MJjrtwh0Os1C9Yrp6nMPcOsGlL58vHNqG2D2MwQrB+mF2yvbAUDUMNhnU+Y5pgOHKsEX M/bA== X-Gm-Message-State: APjAAAVy5dlZOWyrAMYXJFblvGTbukcYPFuv7jqjz5eTrLfMMQ44ZAdn EvjWiHLWSzYkHj/Xvc2DZW8= X-Google-Smtp-Source: APXvYqwvVtARK+C/DVSVImjE1Mpz8h6dEqd7MNelS+DGBLTa+gNCctcK7PEwWB+Z0fTADxEVolYI6w== X-Received: by 2002:aa7:8a53:: with SMTP id n19mr17128829pfa.11.1557526424025; Fri, 10 May 2019 15:13:44 -0700 (PDT) Received: from [192.168.1.70] (c-24-6-192-50.hsd1.ca.comcast.net. [24.6.192.50]) by smtp.gmail.com with ESMTPSA id r5sm6052599pgv.52.2019.05.10.15.13.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 May 2019 15:13:43 -0700 (PDT) Subject: Re: [PATCH v2 00/17] kunit: introduce KUnit, the Linux kernel unit testing framework To: Logan Gunthorpe , Theodore Ts'o , Tim.Bird@sony.com, knut.omang@oracle.com, gregkh@linuxfoundation.org, brendanhiggins@google.com, keescook@google.com, kieran.bingham@ideasonboard.com, mcgrof@kernel.org, robh@kernel.org, sboyd@kernel.org, shuah@kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-um@lists.infradead.org, Alexander.Levin@microsoft.com, amir73il@gmail.com, dan.carpenter@oracle.com, dan.j.williams@intel.com, daniel@ffwll.ch, jdike@addtoit.com, joel@jms.id.au, julia.lawall@lip6.fr, khilman@baylibre.com, mpe@ellerman.id.au, pmladek@suse.com, richard@nod.at, rientjes@google.com, rostedt@goodmis.org, wfg@linux.intel.com References: <20190509015856.GB7031@mit.edu> <580e092f-fa4e-eedc-9e9a-a57dd085f0a6@gmail.com> <20190509032017.GA29703@mit.edu> <7fd35df81c06f6eb319223a22e7b93f29926edb9.camel@oracle.com> <20190509133551.GD29703@mit.edu> <875c546d-9713-bb59-47e4-77a1d2c69a6d@gmail.com> <20190509214233.GA20877@mit.edu> <20190509233043.GC20877@mit.edu> <8914afef-1e66-e6e3-f891-5855768d3018@deltatee.com> <6d6e91ec-33d3-830b-4895-4d7a20ba7d45@gmail.com> <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> From: Frank Rowand Message-ID: Date: Fri, 10 May 2019 15:13:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <3faa022b-0b70-0375-aa6d-12ea83a2671f@deltatee.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 5/10/19 9:17 AM, Logan Gunthorpe wrote: > > > On 2019-05-09 11:18 p.m., Frank Rowand wrote: > >> YES, kselftest has in-kernel tests. (Excuse the shouting...) > > Cool. From my cursory look, in my opinion, these would be greatly > improved by converting them to the framework Brendan is proposing for Kunit. > >>> If they do exists, it seems like it would make sense to >>> convert those to kunit and have Kunit tests run-able in a VM or >>> baremetal instance. >> >> They already run in a VM. >> >> They already run on bare metal. >> >> They already run in UML. > > Simply being able to run in UML is not the only thing here. Kunit > provides the infrastructure to quickly build, run and report results for > all the tests from userspace without needing to worry about the details > of building and running a UML kernel, then parsing dmesg to figure out > what tests were run or not. Yes. But that is not the only environment that KUnit must support to be of use to me for devicetree unittests (this is not new, Brendan is quite aware of my needs and is not ignoring them). >> This is not to say that KUnit does not make sense. But I'm still trying >> to get a better description of the KUnit features (and there are >> some). > > So read the patches, or the documentation[1] or the LWN article[2]. It's > pretty well described in a lot of places -- that's one of the big > advantages of it. In contrast, few people seems to have any concept of > what kselftests are or where they are or how to run them (I was > surprised to find the in-kernel tests in the lib tree). > > Logan > > [1] https://google.github.io/kunit-docs/third_party/kernel/docs/ > [2] https://lwn.net/Articles/780985/ I have been following the RFC versions. I have installed the RFC patches and run them to the extent that they worked (devicetree unittests were a guinea pig for test conversion in the RFC series, but the converted tests did not work). I read portions of the code while trying to understand the unittests conversion. I made review comments based on the portion of the code that I did read. I have read the documentation (very nice btw, as I have said before, but should be expanded). My comment is that the description to submit the patch series should be fuller -- KUnit potentially has a lot of nice attributes, and I still think I have only scratched the surface. The average reviewer may have even less in-depth knowledge than I do. And as I have commented before, I keep diving into areas that I had no previous experience with (such as kselftest) to be able to properly judge this patch series.