From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A86C433E9 for ; Wed, 10 Feb 2021 18:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A965264D73 for ; Wed, 10 Feb 2021 18:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233995AbhBJSQe (ORCPT ); Wed, 10 Feb 2021 13:16:34 -0500 Received: from mx2.suse.de ([195.135.220.15]:50028 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233648AbhBJSPb (ORCPT ); Wed, 10 Feb 2021 13:15:31 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 21398AD6A; Wed, 10 Feb 2021 18:14:50 +0000 (UTC) Subject: Re: [v7 PATCH 04/12] mm: vmscan: remove memcg_shrinker_map_size To: Roman Gushchin , Yang Shi Cc: ktkhai@virtuozzo.com, shakeelb@google.com, david@fromorbit.com, hannes@cmpxchg.org, mhocko@suse.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-5-shy828301@gmail.com> <20210209204314.GG524633@carbon.DHCP.thefacebook.com> From: Vlastimil Babka Message-ID: Date: Wed, 10 Feb 2021 19:14:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210209204314.GG524633@carbon.DHCP.thefacebook.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2/9/21 9:43 PM, Roman Gushchin wrote: > On Tue, Feb 09, 2021 at 09:46:38AM -0800, Yang Shi wrote: >> Both memcg_shrinker_map_size and shrinker_nr_max is maintained, but actually the >> map size can be calculated via shrinker_nr_max, so it seems unnecessary to keep both. >> Remove memcg_shrinker_map_size since shrinker_nr_max is also used by iterating the >> bit map. >> >> Acked-by: Kirill Tkhai >> Signed-off-by: Yang Shi Acked-by: Vlastimil Babka >> --- >> mm/vmscan.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index e4ddaaaeffe2..641077b09e5d 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -185,8 +185,10 @@ static LIST_HEAD(shrinker_list); >> static DECLARE_RWSEM(shrinker_rwsem); >> >> #ifdef CONFIG_MEMCG >> +static int shrinker_nr_max; >> >> -static int memcg_shrinker_map_size; >> +#define NR_MAX_TO_SHR_MAP_SIZE(nr_max) \ >> + (DIV_ROUND_UP(nr_max, BITS_PER_LONG) * sizeof(unsigned long)) > > How about something like this? > > static inline int shrinker_map_size(int nr_items) > { > return DIV_ROUND_UP(nr_items, BITS_PER_LONG) * sizeof(unsigned long); > } > > I think it look less cryptic. Yeah that looks nicer so I'm fine with that potential change. > The rest of the patch looks good to me. > > Thanks! >