linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
To: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org
Cc: Martin Kaiser <lists@kaiser.cx>
Subject: Re: next-20180906 crashes during ubifs_mount (legacy fs_context)
Date: Sun, 9 Sep 2018 00:58:43 +0900	[thread overview]
Message-ID: <d3fffb0f-5a7d-aa9c-cdfd-6cafc38f8cc6@I-love.SAKURA.ne.jp> (raw)
In-Reply-To: <20180908131312.eob2glzykvq5w7dd@viti.kaiser.cx>

Got response from David Howells to a mail I forwarded...

-------- Forwarded Message --------
From: David Howells <dhowells@redhat.com>
In-Reply-To: <62a743d3-80af-8586-8719-e17a224de62f@I-love.SAKURA.ne.jp>
References: <62a743d3-80af-8586-8719-e17a224de62f@I-love.SAKURA.ne.jp> <20180908131312.eob2glzykvq5w7dd@viti.kaiser.cx>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: dhowells@redhat.com, Martin Kaiser <lists@kaiser.cx>
Subject: Re: Fwd: next-20180906 crashes during ubifs_mount (legacy fs_context)
Date: Sat, 08 Sep 2018 16:19:08 +0100
Message-ID: <10870.1536419948@warthog.procyon.org.uk>

Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> wrote:

> I have CONFIG_SECURITY disabled. Enabling it does not change the behaviour.
> 
> Commenting out the -ENOPARAM check makes the mount work again.
> 
> I'm not sure how to fix this.  Is it ok for
> security_fs_context_parse_param() to return 0 when CONFIG_SECURITY is turned
> off? Shouldn't this be -ENOPARAM, meaning "not a parameter I care about"?

Yes.  The default should be -ENOPARAM, both in security.c and security.h.

I've fixed my tree and Al has pulled it, but it won't get into linux-next
until Stephen next refreshes it.

David

      reply	other threads:[~2018-09-08 20:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-08 13:13 Martin Kaiser
2018-09-08 15:58 ` Tetsuo Handa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3fffb0f-5a7d-aa9c-cdfd-6cafc38f8cc6@I-love.SAKURA.ne.jp \
    --to=penguin-kernel@i-love.sakura.ne.jp \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=lists@kaiser.cx \
    --subject='Re: next-20180906 crashes during ubifs_mount (legacy fs_context)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).