From: Markus Elfring <Markus.Elfring@web.de>
To: devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org,
"Sasha Levin" <alexander.levin@microsoft.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: exfat: add exfat filesystem code to staging
Date: Thu, 29 Aug 2019 17:44:59 +0200 [thread overview]
Message-ID: <d5c289ef-6c5c-ecdc-0e73-c5bd410b3d26@web.de> (raw)
In-Reply-To: <20190828160817.6250-1-gregkh@linuxfoundation.org>
> +++ b/drivers/staging/exfat/exfat_core.c
> @@ -0,0 +1,3704 @@
…
> +static s32 __load_upcase_table(struct super_block *sb, sector_t sector,
> + u32 num_sectors, u32 utbl_checksum)
> +{
…
> +error:
An other label would be nicer, wouldn't it?
> + if (tmp_bh)
> + brelse(tmp_bh);
This inline function tolerates the passing of null pointers.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/buffer_head.h?id=9cf6b756cdf2cd38b8b0dac2567f7c6daf5e79d5#n292
https://elixir.bootlin.com/linux/v5.3-rc6/source/include/linux/buffer_head.h#L292
Thus I suggest to omit the extra pointer check at affected places.
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -0,0 +1,4137 @@
…
> +// FIXME use commented lines
> +// static int exfat_default_codepage = CONFIG_EXFAT_DEFAULT_CODEPAGE;
Is such information still relevant anyhow?
> +static int exfat_fill_super(struct super_block *sb, void *data, int silent)
> +{
…
> +out_fail:
> + if (root_inode)
> + iput(root_inode);
I am informed in the way that this function tolerates the passing
of null pointers.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/fs/inode.c?id=9cf6b756cdf2cd38b8b0dac2567f7c6daf5e79d5#n1564
https://elixir.bootlin.com/linux/v5.3-rc6/source/fs/inode.c#L1564
Thus I suggest to omit the extra pointer check also at this place.
Regards,
Markus
next prev parent reply other threads:[~2019-08-29 15:45 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190828160817.6250-1-gregkh@linuxfoundation.org>
2019-08-28 17:00 ` [PATCH] staging: exfat: add exfat filesystem code to staging Greg Kroah-Hartman
2019-08-29 6:23 ` Christoph Hellwig
2019-08-29 6:39 ` Greg Kroah-Hartman
2019-08-29 9:41 ` Christoph Hellwig
2019-08-29 9:50 ` Greg Kroah-Hartman
2019-08-29 10:37 ` Christoph Hellwig
2019-08-29 11:04 ` Gao Xiang
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 11:18 ` Greg Kroah-Hartman
2019-08-29 15:11 ` Dan Carpenter
2019-08-29 15:27 ` Gao Xiang
2019-08-29 15:43 ` Dan Carpenter
2019-08-29 15:51 ` Gao Xiang
2019-08-29 16:04 ` Gao Xiang
2019-08-30 8:34 ` Dan Carpenter
2019-08-30 8:43 ` Gao Xiang
2019-08-30 11:26 ` Dan Carpenter
2019-08-30 12:04 ` Gao Xiang
2019-08-29 16:44 ` Gao Xiang
2019-08-29 16:59 ` Joe Perches
2019-08-29 17:02 ` Gao Xiang
2019-08-30 2:06 ` Chao Yu
2019-08-30 6:38 ` Gao Xiang
2019-08-30 12:00 ` Checking usage of likeliness annotations Markus Elfring
2019-08-30 11:51 ` [PATCH] staging: exfat: add exfat filesystem code to staging David Sterba
2019-08-31 3:50 ` Chao Yu
2019-08-30 15:36 ` Christoph Hellwig
2019-08-30 21:54 ` Dave Chinner
2019-08-31 10:31 ` Valdis Klētnieks
2019-09-01 0:04 ` Dave Chinner
2019-08-29 7:01 ` Gao Xiang
2019-08-29 8:24 ` Gao Xiang
2019-08-29 9:51 ` Christoph Hellwig
2019-08-29 12:14 ` Pali Rohár
2019-08-29 12:34 ` Valdis Klētnieks
2019-08-29 12:46 ` Pali Rohár
2019-08-29 14:08 ` Markus Elfring
2019-08-29 15:44 ` Markus Elfring [this message]
2019-08-29 20:56 ` Pali Rohár
2019-08-29 23:18 ` Valdis Klētnieks
2019-08-29 23:35 ` Sasha Levin
2019-08-30 7:56 ` Pali Rohár
2019-10-16 14:03 ` Pali Rohár
2019-10-16 14:31 ` Sasha Levin
2019-10-16 16:03 ` Pali Rohár
2019-10-16 16:20 ` Sasha Levin
2019-10-16 16:22 ` Greg Kroah-Hartman
2019-10-16 16:32 ` Pali Rohár
2019-10-16 16:50 ` Greg Kroah-Hartman
2019-10-16 20:33 ` Sasha Levin
2019-10-16 21:53 ` Valdis Klētnieks
2019-10-17 7:53 ` Pali Rohár
2019-10-17 7:50 ` Pali Rohár
2020-02-13 0:06 ` Pali Rohár
2020-02-13 21:18 ` Sasha Levin
2020-02-14 22:16 ` Valdis Klētnieks
2020-02-14 22:43 ` Pali Rohár
2020-02-14 23:25 ` Valdis Klētnieks
2020-04-21 21:30 ` exfat upcase table for code points above U+FFFF (Was: Re: [PATCH] staging: exfat: add exfat filesystem code to staging) Pali Rohár
2020-04-27 15:49 ` Sasha Levin
2020-04-28 7:46 ` Pali Rohár
2019-10-16 16:05 ` [PATCH] staging: exfat: add exfat filesystem code to staging Valdis Klētnieks
2019-08-30 8:03 ` Pali Rohár
2019-08-30 15:40 ` Christoph Hellwig
2019-08-30 15:43 ` Pali Rohár
2019-09-14 13:39 ` [PATCH] staging: exfat: add exfat filesystem code to Park Ju Hyung
2019-09-15 13:54 ` Greg KH
2019-09-15 16:11 ` Ju Hyung Park
[not found] ` <20190918195920.25210-1-qkrwngud825@gmail.com>
2019-09-18 20:12 ` [PATCH] staging: exfat: rebase to sdFAT v2.2.0 Greg KH
2019-09-18 20:13 ` Greg KH
2019-09-18 20:22 ` Ju Hyung Park
2019-09-18 20:26 ` Greg KH
2019-09-18 20:31 ` Ju Hyung Park
2019-09-18 20:46 ` Valdis Klētnieks
2019-09-18 21:31 ` kbuild test robot
2019-09-18 21:31 ` kbuild test robot
2019-09-18 22:17 ` Ju Hyung Park
2019-10-24 9:39 ` [PATCH] staging: exfat: add exfat filesystem code to staging Pali Rohár
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5c289ef-6c5c-ecdc-0e73-c5bd410b3d26@web.de \
--to=markus.elfring@web.de \
--cc=alexander.levin@microsoft.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).