From: Ian Kent <raven@themaw.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
autofs mailing list <autofs@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS
Date: Mon, 21 May 2018 12:17:49 +0800 [thread overview]
Message-ID: <d6096c21-1c0f-266f-8541-29f0726fe349@themaw.net> (raw)
In-Reply-To: <c0eb4d04-9d75-7fc2-0bce-f2caac9d2056@infradead.org>
On 21/05/18 10:08, Randy Dunlap wrote:
> On 05/20/2018 06:04 PM, Ian Kent wrote:
>> Setting AUTOFS_FS and AUTOFS4_FS to y or m results in a compile
>> failure.
>>
>> It isn't possible to unset one if the other is set because it
>> introduces a circular dependency.
>>
>> But adding "depends on AUTOFS_FS = n && AUTOFS_FS != m" will make
>> autofs4 appear under the autofs entry which should call attention
>> to it. It also results in AUTOFS4_FS being removed from .config
>> for any setting of AUTOFS_FS except n.
Arrgh!
I missed that "&& AUTOFS_FS != m" in the description.
Andrew, let me re-post this patch with this fixed and with the
added annotations for Randy below.
>>
>> Adding a "NOTE" to the AUTOFS4_FS help text will hopefully raise
>> awareness of the change to smooth the transition.
>>
>> Signed-off-by: Ian Kent <raven@themaw.net>
>> Cc: Randy Dunlap <rdunlap@infradead.org>
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
>> ---
>> fs/autofs4/Kconfig | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/fs/autofs4/Kconfig b/fs/autofs4/Kconfig
>> index 53bc592a250d..2c2fdf989f90 100644
>> --- a/fs/autofs4/Kconfig
>> +++ b/fs/autofs4/Kconfig
>> @@ -1,6 +1,7 @@
>> config AUTOFS4_FS
>> tristate "Kernel automounter version 4 support (also supports v3 and v5)"
>> default n
>> + depends on AUTOFS_FS = n
>> help
>> The automounter is a tool to automatically mount remote file systems
>> on demand. This implementation is partially kernel-based to reduce
>> @@ -30,3 +31,10 @@ config AUTOFS4_FS
>> - any "alias autofs autofs4" will need to be removed.
>>
>> Please configure AUTOFS_FS instead of AUTOFS4_FS from now on.
>> +
>> + NOTE: Since the modules autofs and autofs4 use the same file system
>> + type name of "autofs" only one can be built. The "depends"
>> + above will result in AUTOFS4_FS not appearing in .config for
>> + any setting of AUTOFS_FS other than n and AUTOFS4_FS will
>> + appear under the AUTOFS_FS entry otherwise which is intended
>> + to draw attention to the module rename change.
>>
>
>
prev parent reply other threads:[~2018-05-21 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-21 1:04 [PATCH] autofs - make autofs4 Kconfig depend on AUTOFS_FS Ian Kent
2018-05-21 2:08 ` Randy Dunlap
2018-05-21 4:17 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6096c21-1c0f-266f-8541-29f0726fe349@themaw.net \
--to=raven@themaw.net \
--cc=akpm@linux-foundation.org \
--cc=autofs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).