From: Rasmus Villemoes <linux@rasmusvillemoes.dk>
To: syzbot <syzbot+3c01db6025f26530cf8d@syzkaller.appspotmail.com>,
agruenba@redhat.com, darrick.wong@oracle.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk
Subject: Re: INFO: task hung in pipe_write (2)
Date: Thu, 19 Sep 2019 22:55:44 +0200 [thread overview]
Message-ID: <d9a957b3-9f0a-20b5-588a-64ca4722d433@rasmusvillemoes.dk> (raw)
In-Reply-To: <000000000000ac6a360592eb26c1@google.com>
On 19/09/2019 19.19, syzbot wrote:
> Hello,
>
> syzbot found the following crash on:
>
> HEAD commit: 288b9117 Add linux-next specific files for 20190918
> git tree: linux-next
> console output: https://syzkaller.appspot.com/x/log.txt?x=17e86645600000
> kernel config: https://syzkaller.appspot.com/x/.config?x=f6126e51304ef1c3
> dashboard link:
> https://syzkaller.appspot.com/bug?extid=3c01db6025f26530cf8d
> compiler: gcc (GCC) 9.0.0 20181231 (experimental)
> syz repro: https://syzkaller.appspot.com/x/repro.syz?x=11855769600000
> C reproducer: https://syzkaller.appspot.com/x/repro.c?x=143580a1600000
>
> The bug was bisected to:
>
> commit cfb864757d8690631aadf1c4b80022c18ae865b3
> Author: Darrick J. Wong <darrick.wong@oracle.com>
> Date: Tue Sep 17 16:05:22 2019 +0000
>
> splice: only read in as much information as there is pipe buffer space
The middle hunk (the one before splice_pipe_to_pipe()) accesses
opipe->{buffers, nrbufs}, but opipe is not locked at that point. So
maybe we end up passing len==0, which seems (once there's room in opipe)
it would put a zero-length pipe_buffer in opipe - and that probably
violates an invariant somewhere.
But does the splice_pipe_to_pipe() case even need that extra logic?
Doesn't it handle short writes correctly already?
Rasmus
next prev parent reply other threads:[~2019-09-19 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-19 17:19 INFO: task hung in pipe_write (2) syzbot
2019-09-19 20:55 ` Rasmus Villemoes [this message]
2019-09-19 21:10 ` Darrick J. Wong
2019-10-14 20:40 ` Andreas Gruenbacher
2019-10-14 22:16 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9a957b3-9f0a-20b5-588a-64ca4722d433@rasmusvillemoes.dk \
--to=linux@rasmusvillemoes.dk \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+3c01db6025f26530cf8d@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).