From: Christophe Leroy <christophe.leroy@c-s.fr>
To: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jeremy Kerr <jk@ozlabs.org>,
linux-fsdevel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
"Eric W . Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 2/7] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32
Date: Tue, 28 Apr 2020 09:45:46 +0200 [thread overview]
Message-ID: <ddbaba35-9cc5-dfb9-3cae-51b026de5b65@c-s.fr> (raw)
In-Reply-To: <20200428070935.GE18754@lst.de>
Le 28/04/2020 à 09:09, Christoph Hellwig a écrit :
> On Mon, Apr 27, 2020 at 03:40:50PM -0700, Andrew Morton wrote:
>>> https://www.spinics.net/lists/kernel/msg3473847.html
>>> https://www.spinics.net/lists/kernel/msg3473840.html
>>> https://www.spinics.net/lists/kernel/msg3473843.html
>>
>> OK, but that doesn't necessitate the above monstrosity? How about
>>
>> static int __copy_siginfo_to_user32(struct compat_siginfo __user *to,
>> const struct kernel_siginfo *from, bool x32_ABI)
>> {
>> struct compat_siginfo new;
>> copy_siginfo_to_external32(&new, from);
>> ...
>> }
>>
>> int copy_siginfo_to_user32(struct compat_siginfo __user *to,
>> const struct kernel_siginfo *from)
>> {
>> #if defined(CONFIG_X86_X32_ABI) || defined(CONFIG_IA32_EMULATION)
>> return __copy_siginfo_to_user32(to, from, in_x32_syscall());
>> #else
>> return __copy_siginfo_to_user32(to, from, 0);
>> #endif
>> }
>>
>> Or something like that - I didn't try very hard. We know how to do
>> this stuff, and surely this thing isn't how!
>
> I guess that might be a worthwhile middle ground. Still not a fan of
> all these ifdefs..
>
Can't we move the small X32 specific part out of
__copy_siginfo_to_user32(), in an arch specific helper that voids for
other architectures ?
Something like:
if (!arch_special_something(&new, from)) {
new.si_utime = from->si_utime;
new.si_stime = from->si_stime;
}
Then the arch_special_something() does what it wants in x86 and returns
1, and for architectures not implementating it, a generic version return
0 all the time.
Christophe
next prev parent reply other threads:[~2020-04-28 7:46 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 15:41 remove set_fs calls from the exec and coredump code v3 Christoph Hellwig
2020-04-21 15:41 ` [PATCH 1/7] powerpc/spufs: simplify spufs core dumping Christoph Hellwig
2020-04-21 18:49 ` Al Viro
2020-04-21 19:01 ` Christoph Hellwig
2020-04-21 19:19 ` Al Viro
2020-04-21 19:25 ` Al Viro
2020-04-21 15:41 ` [PATCH 2/7] signal: factor copy_siginfo_to_external32 from copy_siginfo_to_user32 Christoph Hellwig
2020-04-26 4:47 ` Andrew Morton
2020-04-26 7:40 ` Christoph Hellwig
2020-04-27 22:40 ` Andrew Morton
2020-04-28 7:09 ` Christoph Hellwig
2020-04-28 7:45 ` Christophe Leroy [this message]
2020-04-28 7:48 ` Christoph Hellwig
2020-04-28 19:56 ` [PATCH] fixup! " Arnd Bergmann
2020-04-29 6:17 ` Christophe Leroy
2020-04-29 6:29 ` Christoph Hellwig
2020-04-29 6:44 ` Christoph Hellwig
2020-04-29 8:07 ` Arnd Bergmann
2020-04-29 9:42 ` Christoph Hellwig
2020-04-29 11:28 ` Arnd Bergmann
2020-04-29 11:53 ` Christoph Hellwig
2020-04-29 12:34 ` Arnd Bergmann
2020-04-21 15:42 ` [PATCH 3/7] binfmt_elf: femove the set_fs in fill_siginfo_note Christoph Hellwig
2020-04-21 15:42 ` [PATCH 4/7] binfmt_elf: remove the set_fs(KERNEL_DS) in elf_core_dump Christoph Hellwig
2020-04-21 15:42 ` [PATCH 5/7] binfmt_elf_fdpic: remove the set_fs(KERNEL_DS) in elf_fdpic_core_dump Christoph Hellwig
2020-04-21 15:42 ` [PATCH 6/7] exec: simplify the copy_strings_kernel calling convention Christoph Hellwig
2020-04-21 15:42 ` [PATCH 7/7] exec: open code copy_string_kernel Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ddbaba35-9cc5-dfb9-3cae-51b026de5b65@c-s.fr \
--to=christophe.leroy@c-s.fr \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=ebiederm@xmission.com \
--cc=hch@lst.de \
--cc=jk@ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).