From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBFDCC433FF for ; Mon, 5 Aug 2019 22:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD8F5214C6 for ; Mon, 5 Aug 2019 22:12:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bnxLQDCy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730707AbfHEWMo (ORCPT ); Mon, 5 Aug 2019 18:12:44 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:15630 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727928AbfHEWMo (ORCPT ); Mon, 5 Aug 2019 18:12:44 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 05 Aug 2019 15:12:53 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Mon, 05 Aug 2019 15:12:43 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Mon, 05 Aug 2019 15:12:43 -0700 Received: from [10.110.48.28] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 5 Aug 2019 22:12:42 +0000 Subject: Re: [PATCH] fs/io_uring.c: convert put_page() to put_user_page*() To: Ira Weiny , CC: Andrew Morton , Christoph Hellwig , Jan Kara , Jason Gunthorpe , Jerome Glisse , LKML , , , Alexander Viro , Jens Axboe , References: <20190805023206.8831-1-jhubbard@nvidia.com> <20190805220441.GA23416@iweiny-DESK2.sc.intel.com> <20190805220547.GB23416@iweiny-DESK2.sc.intel.com> From: John Hubbard X-Nvconfidentiality: public Message-ID: Date: Mon, 5 Aug 2019 15:12:42 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20190805220547.GB23416@iweiny-DESK2.sc.intel.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1565043173; bh=LkAiUo1s42CQYX53EPRAoniYSqypvtE8JhgF1ACTWJI=; h=X-PGP-Universal:Subject:To:CC:References:From:X-Nvconfidentiality: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=bnxLQDCyTODHWtH8f0QtXRcjnq5ZXER2WiGKW2qcCasfwe2n/ifRFjrKGHdyPOppn UvjQryp87QwL1sEmtQkKSxJDk/DZbvhqo+mDHQVATQ9bBcoKnLRVQZiK9wAKkQ0DdD Vs8tjYGY4h6UomzREoaPHuLbgC1/FrH1JcqhpCHDAF0gBBzIrmrClfnBUsOwA0/j9u PsvNWbbA7QRj75rUXOs05jEZLR3w7rJ4pZ8TDwjzAXpDSY7XDp7GNz9t5A3GCeDz0C mK1bTIxkCObFVZpc/YzRFWLAFY8D44N5xtlkq8ihB9nG04UOs+yqRWzkLpjzL4j7XF R+Vw9vNjJ4jPw== Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 8/5/19 3:05 PM, Ira Weiny wrote: > On Mon, Aug 05, 2019 at 03:04:42PM -0700, 'Ira Weiny' wrote: >> On Sun, Aug 04, 2019 at 07:32:06PM -0700, john.hubbard@gmail.com wrote: >>> From: John Hubbard >>> >>> For pages that were retained via get_user_pages*(), release those pages >>> via the new put_user_page*() routines, instead of via put_page() or >>> release_pages(). >>> >>> This is part a tree-wide conversion, as described in commit fc1d8e7cca2d >>> ("mm: introduce put_user_page*(), placeholder versions"). >>> >>> Cc: Alexander Viro >>> Cc: Jens Axboe >>> Cc: linux-fsdevel@vger.kernel.org >>> Cc: linux-block@vger.kernel.org >>> Signed-off-by: John Hubbard >> >> Signed-off-by: Ira Weiny > > > > I meant to say I wrote the same patch ... For this one... > > Reviewed-by: Ira Weiny > Hi Ira, Say, in case you or anyone else is up for it: there are still about two thirds of the 34 patches that could use a reviewed-by, in this series: https://lore.kernel.org/r/20190804224915.28669-1-jhubbard@nvidia.com ...and even reviewing one or two quick ones would help--no need to look at all of them, especially if several people each look at a few. Also note that I'm keeping the gup_dma_core branch tracking the latest linux.git, and it seems to be working pretty well, aside from one warning that I haven't yet figured out (as per the latest commit): git@github.com:johnhubbard/linux.git thanks, -- John Hubbard NVIDIA