From: Aurelien Thierry <aurelien.thierry@quoscient.io>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] fs: relatime update - Match comment with behavior
Date: Tue, 18 Jun 2019 13:43:56 +0200 [thread overview]
Message-ID: <df00a31b-c77e-ba44-d032-a01fcbad8ff8@quoscient.io> (raw)
In-Reply-To: <20190618011216.GY17978@ZenIV.linux.org.uk>
You are right.
As atime and mtime are timestamps and not "live" objects, I understood
their age as being the actual timestamp and thus I understood "mtime is
younger than atime" the other way around.
So this can be a fix for better clarity ("earlier" is used in other
places rather than "younger") but the current comments are not wrong.
On 6/18/19 3:12 AM, Al Viro wrote:
> On Tue, Jun 11, 2019 at 07:45:40AM +0200, Aurelien Thierry wrote:
>> 2 comments right before code wrongly state that if (c|m)time is younger
>> than atime, then atime is updated (behavior is the other way around).
>>
>> Fix aligns comments with actual behavior, function description and
>> documentation (man mount).
>
> Huh? "mtime is younger than atime" means that mtime refers to the moment
> later than that refered to by atime, i.e that atime refers to the moment
> earlier than that refered to by mtime. What is the problem you are trying
> to fix?
>
> Both the original and changed comments mean exact same thing. And yes,
> the changed comment does match the actual behaviour. Just as the original
> one does...
>
prev parent reply other threads:[~2019-06-18 11:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 5:45 [PATCH] fs: relatime update - Match comment with behavior Aurelien Thierry
2019-06-18 1:12 ` Al Viro
2019-06-18 11:43 ` Aurelien Thierry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=df00a31b-c77e-ba44-d032-a01fcbad8ff8@quoscient.io \
--to=aurelien.thierry@quoscient.io \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trivial@kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).