linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Kaitao Cheng <pilgrimtao@gmail.com>, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Colin Ian King <colin.king@canonical.com>,
	Matthew Wilcox <willy@infradead.org>,
	Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v2] proc/fd: Adjust variable initialisations in seq_show()
Date: Tue, 7 Jul 2020 09:23:47 +0200	[thread overview]
Message-ID: <e0c48e5a-650d-b475-abe8-32315f2b6ac9@web.de> (raw)
In-Reply-To: <20200612160946.21187-1-pilgrimtao@gmail.com>

> 'files' will be immediately reassigned. 'f_flags' and 'file' will be
> overwritten in the if{} or seq_show() directly exits with an error.
> so we don't need to consume CPU resources to initialize them.

How do you think about to reduce the scope for four local variables
in this function implementation?
https://refactoring.com/catalog/reduceScopeOfVariable.html

Regards,
Markus

      parent reply	other threads:[~2020-07-07  7:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 16:09 [PATCH v2] proc/fd: Remove unnecessary {files, f_flags, file} initialization in seq_show() Kaitao Cheng
2020-06-12 16:45 ` [PATCH v2] proc/fd: Remove unnecessary variable initialisations " Markus Elfring
2020-06-12 17:00   ` Matthew Wilcox
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:03     ` Markus Elfring
2020-06-12 17:04       ` Matthew Wilcox
2020-06-12 18:22         ` [v2] " Markus Elfring
2020-06-12 18:28           ` Matthew Wilcox
2020-06-12 18:43             ` Markus Elfring
2020-06-12 18:47               ` Matthew Wilcox
2020-06-12 19:00                 ` Markus Elfring
2020-06-12 19:00                 ` Markus Elfring
2020-06-12 19:02                   ` Matthew Wilcox
2020-06-12 19:49                   ` Al Viro
2020-06-14  7:12   ` [PATCH v2] " Greg KH
2020-07-07  7:23 ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e0c48e5a-650d-b475-abe8-32315f2b6ac9@web.de \
    --to=markus.elfring@web.de \
    --cc=adobriyan@gmail.com \
    --cc=colin.king@canonical.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pilgrimtao@gmail.com \
    --cc=songmuchun@bytedance.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).