From: Stephen Smalley <sds@tycho.nsa.gov>
To: Tong Zhang <ztong@vt.edu>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, wenbo.s@samsung.com
Subject: Re: Leaking path for search_binary_handler
Date: Wed, 26 Sep 2018 08:59:38 -0400 [thread overview]
Message-ID: <e36e7259-5cf8-3c5b-98d3-5c4d5c4b82b1@tycho.nsa.gov> (raw)
In-Reply-To: <C2D9C687-4964-4DB3-AAF4-7C836324D6BE@vt.edu>
On 09/25/2018 01:27 PM, Tong Zhang wrote:
> Kernel Version: 4.18.5
>
> Problem Description:
>
> search_binary_handler() should be called after setting bprm using prepare_binprm(),
> and in prepare_binprm(), there’s a LSM hook security_bprm_set_creds(),
> which can make a decision that binfmt cares.
>
> We found a leaking path In fs/binfmt_misc.c:235, that don’t ask LSM’s decision.
Do you mean the MISC_FMT_CREDENTIALS case? That looks intentional to me,
as noted in the comment there, and as per
Documentation/admin-guide/binfmt-misc.rst's discussion of the
credentials flag.
prev parent reply other threads:[~2018-09-26 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-25 17:27 Leaking path for search_binary_handler Tong Zhang
2018-09-26 12:59 ` Stephen Smalley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e36e7259-5cf8-3c5b-98d3-5c4d5c4b82b1@tycho.nsa.gov \
--to=sds@tycho.nsa.gov \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=wenbo.s@samsung.com \
--cc=ztong@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).