From: Jens Axboe <axboe@kernel.dk>
To: Maxim Mikityanskiy <maxtram95@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>
Cc: linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance
Date: Wed, 27 Jan 2021 09:15:02 -0700 [thread overview]
Message-ID: <eac57824-f2eb-9a81-aa5f-3fd62f8e531d@kernel.dk> (raw)
In-Reply-To: <20210126195907.2273494-1-maxtram95@gmail.com>
On 1/26/21 12:59 PM, Maxim Mikityanskiy wrote:
> The cited commit introduced a serious regression with SATA write speed,
> as found by bisecting. This patch reverts this commit, which restores
> write speed back to the values observed before this commit.
>
> The performance tests were done on a Helios4 NAS (2nd batch) with 4 HDDs
> (WD8003FFBX) using dd (bs=1M count=2000). "Direct" is a test with a
> single HDD, the rest are different RAID levels built over the first
> partitions of 4 HDDs. Test results are in MB/s, R is read, W is write.
>
> | Direct | RAID0 | RAID10 f2 | RAID10 n2 | RAID6
> ----------------+--------+-------+-----------+-----------+--------
> 9011495c9466 | R:256 | R:313 | R:276 | R:313 | R:323
> (before faulty) | W:254 | W:253 | W:195 | W:204 | W:117
> ----------------+--------+-------+-----------+-----------+--------
> 5ff9f19231a0 | R:257 | R:398 | R:312 | R:344 | R:391
> (faulty commit) | W:154 | W:122 | W:67.7 | W:66.6 | W:67.2
> ----------------+--------+-------+-----------+-----------+--------
> 5.10.10 | R:256 | R:401 | R:312 | R:356 | R:375
> unpatched | W:149 | W:123 | W:64 | W:64.1 | W:61.5
> ----------------+--------+-------+-----------+-----------+--------
> 5.10.10 | R:255 | R:396 | R:312 | R:340 | R:393
> patched | W:247 | W:274 | W:220 | W:225 | W:121
>
> Applying this patch doesn't hurt read performance, while improves the
> write speed by 1.5x - 3.5x (more impact on RAID tests). The write speed
> is restored back to the state before the faulty commit, and even a bit
> higher in RAID tests (which aren't HDD-bound on this device) - that is
> likely related to other optimizations done between the faulty commit and
> 5.10.10 which also improved the read speed.
Can't argue with these numbers, and while this should probably get
fixed up instead, let's leave that for future kernels. I'll apply this
for 5.11, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-01-27 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 19:59 [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance Maxim Mikityanskiy
2021-01-27 4:23 ` Bart Van Assche
2021-01-27 7:44 ` Maxim Mikityanskiy
2021-01-27 15:18 ` Ming Lei
2021-01-27 16:12 ` Christoph Hellwig
2021-01-27 16:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eac57824-f2eb-9a81-aa5f-3fd62f8e531d@kernel.dk \
--to=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).