From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF817C2D0A3 for ; Fri, 6 Nov 2020 15:01:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 579292067B for ; Fri, 6 Nov 2020 15:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=toxicpanda-com.20150623.gappssmtp.com header.i=@toxicpanda-com.20150623.gappssmtp.com header.b="WU1eEvkr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727291AbgKFPBj (ORCPT ); Fri, 6 Nov 2020 10:01:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727055AbgKFPBj (ORCPT ); Fri, 6 Nov 2020 10:01:39 -0500 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57E1AC0613D2 for ; Fri, 6 Nov 2020 07:01:39 -0800 (PST) Received: by mail-qk1-x742.google.com with SMTP id y197so1281912qkb.7 for ; Fri, 06 Nov 2020 07:01:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gv3NhhJYilcQa5FbCjmuJ9ZNgOEq1qCdNDP7mOzTP3g=; b=WU1eEvkrTkBTE+n8eEWxQ7t4CBoEp4URQy7JP1a1k9Czq+v54nRfN89kKywfWiARJf onLSgfzeVVoeFx18ODMtiYvv9qJAKFbzjXwckCnepqv9aCy5Z9W7/UOjBJWiDjwgMiLp CjDxzs6IKTpTX73qIgseUXYS31GE4j71VYyYOJMYEH89tRzrG7SsQhwBjp2ZTnHhhZL2 BVhHUVBMo7j8GzYj1NqOnCU2nZK8KKOcnGPujf7d5bAzvmf8dRFB4fTJXLFcgdzCo00a L1w9fbil1t7ItJMz16+ax37ekokN2DRKbx4U/FGENTUbLb0CzP+0hIli945CO7+oKrnO Bu9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gv3NhhJYilcQa5FbCjmuJ9ZNgOEq1qCdNDP7mOzTP3g=; b=EOFWuLWhHPirNF95Gabb2j7oQ6l9mcdDGT3hCDvIzbKsHe+j7w5NH5Zz0yOGAyHmJO mCMVuD9I4tKoZrXVO/onrcpjpAs3K4nr5SICvURBPwY7rejep/gtPSfVplNrH6k8HD9l IBjjg3BOCzlZvkPWpHtDLzIBo5LKZF4JKZ4ozwReSDXBucoRcUNQWWQJcwnLLnjOqZv1 sCbv4u0621lbFRxV4BDNJROCEfzby28UATfqwOTWpkxWHG+iLjUARgbiORMdWYqn3RTX GCAiYtXUYF3+DcFmUdPRQdFliP/X1TvN6aTIME6+RZFm4bQ9eVVoZChJjQqXBMa8XqKl 4z8A== X-Gm-Message-State: AOAM532A/MnjQPQWjI7ZYGlk+vDkc0CTlWJbcjp+tzPq2Kshk63akl7J gJ61gB2A12k00kLVLDUX2+Reo/d9qvIWWKet X-Google-Smtp-Source: ABdhPJyeFHZKR/8/Q5FCvuY4JuRkTxXlu3v+50Wgld2madreMoowiskbrhsFw78NGNkjN6Z1+NssaQ== X-Received: by 2002:a05:620a:c9a:: with SMTP id q26mr1008263qki.272.1604674897939; Fri, 06 Nov 2020 07:01:37 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id p5sm687353qtu.13.2020.11.06.07.01.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2020 07:01:36 -0800 (PST) Subject: Re: [PATCH v9 19/41] btrfs: redirty released extent buffers in ZONED mode To: Johannes Thumshirn , Naohiro Aota , "linux-btrfs@vger.kernel.org" , "dsterba@suse.com" Cc: "hare@suse.com" , "linux-fsdevel@vger.kernel.org" References: <6d61ed1d-1801-5710-beac-03d363871ec8@toxicpanda.com> From: Josef Bacik Message-ID: Date: Fri, 6 Nov 2020 10:01:35 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 11/6/20 4:11 AM, Johannes Thumshirn wrote: > On 03/11/2020 15:43, Josef Bacik wrote: >> This is a lot of work when you could just add >> >> if (btrfs_is_zoned(fs_info)) >> return; >> >> to btrfs_clean_tree_block(). The dirty secret is we don't actually unset the >> bits in the transaction io tree because it would require memory allocation >> sometimes, so you don't even need to mess with ->dirty_pages in the first place. >> The only thing you need is to keep from clearing the EB dirty. In fact you >> could just do >> >> if (btrfs_is_zoned(fs_info)) { >> memzero_extent_buffer(eb, 0, eb->len); >> set_bit(EXTENT_BUFFER_NO_CHECK, &eb->bflags); >> } >> >> to btrfs_clean_tree_block() and then in btrfs_free_tree_block() make sure we >> always pin the extent if we're zoned. Thanks, > > As much as I'd love the simple solution you described it unfortunately didn't work > in our testing [1]. So unless I did something completely stupid [2] (which always > is an option) I don't think we can go with the easy solution here, unfortunately. > Actually it's because we're calling btrfs_clean_tree_block() in btrfs_init_new_buffer(), so any new block is now getting marked as BUFFER_NO_CHECk, hence everything blowing up. I think first you push btrfs_clean_tree_block() into btrfs_free_tree_block() and kill all other callers, because we're just marking it no longer dirty. In fact I'd rename it as btrfs_mark_extent_buffer_clean() or something like that. Then your patch should work just fine. Thanks, Josef