linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Asleson <tasleson@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Linux FS Devel <linux-fsdevel@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] buffer_io_error: Use dev_err_ratelimited
Date: Wed, 28 Oct 2020 16:05:37 -0500	[thread overview]
Message-ID: <ec93ba9e-ead9-f49a-d569-abf4c06a60eb@redhat.com> (raw)
In-Reply-To: <71148b03-d880-8113-bd91-25dadef777c7@redhat.com>

On 10/28/20 3:45 PM, Tony Asleson wrote:
> On 10/26/20 5:07 PM, Andy Shevchenko wrote:

>>> +       dev_err_ratelimited(gendev,
>>> +               "Buffer I/O error, logical block %llu%s\n",
>>
>>> +               (unsigned long long)bh->b_blocknr, msg);
>>
>> It's a u64 always (via sector_t), do we really need a casting?
> 
> That's a good question, grepping around shows *many* instances of this
> being done.  I do agree that this doesn't seem to be needed, but maybe
> there is a reason why it's done?

According to this:

https://www.kernel.org/doc/html/v5.9/core-api/printk-formats.html

This should be left as it is, because 'sector_t' is dependent on a
config option.

-Tony


  reply	other threads:[~2020-10-29  2:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26 15:57 [PATCH] buffer_io_error: Use dev_err_ratelimited Tony Asleson
2020-10-26 22:07 ` Andy Shevchenko
2020-10-28 20:45   ` Tony Asleson
2020-10-28 21:05     ` Tony Asleson [this message]
2020-10-28 23:22       ` Andy Shevchenko
2020-11-17 20:38         ` Tony Asleson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec93ba9e-ead9-f49a-d569-abf4c06a60eb@redhat.com \
    --to=tasleson@redhat.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).