[PATCH 1/1] iomap: simplify header file include guard macro definition

[PATCH 1/1] iomap: simplify header file include guard macro definition

[Shan Hai]

The simple definition of a macro is enough for the include guard, it's not
necessary to assign a value to it, so remove the assignment.

Signed-off-by: Shan Hai <shan.hai@oracle.com>
---
 include/linux/iomap.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/iomap.h b/include/linux/iomap.h
index a044a82..25aa7d8 100644
--- a/include/linux/iomap.h
+++ b/include/linux/iomap.h
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef LINUX_IOMAP_H
-#define LINUX_IOMAP_H 1
+#define LINUX_IOMAP_H
 
 #include <linux/types.h>
 
-- 
2.7.4

Re: [PATCH 1/1] iomap: simplify header file include guard macro definition

[Christoph Hellwig]

On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote:
> The simple definition of a macro is enough for the include guard, it's not
> necessary to assign a value to it, so remove the assignment.
> 
> Signed-off-by: Shan Hai <shan.hai@oracle.com>

And what is the exact benefit of changing this?

Re: [PATCH 1/1] iomap: simplify header file include guard macro definition

[Matthew Wilcox]

On Tue, Jul 17, 2018 at 03:13:49PM +0200, Christoph Hellwig wrote:
> On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote:
> > The simple definition of a macro is enough for the include guard, it's not
> > necessary to assign a value to it, so remove the assignment.
> > 
> > Signed-off-by: Shan Hai <shan.hai@oracle.com>
> 
> And what is the exact benefit of changing this?

doesn't seem worthwhile to me either.  If anything's going to change,
it should probably be _LINUX_IOMAP_H (insofaras we have a standard for
include guards, a single _ seems to be preferred)

Re: [PATCH 1/1] iomap: simplify header file include guard macro definition

[Shan Hai]

On 2018年07月17日 21:13, Christoph Hellwig wrote:
> On Mon, Jul 16, 2018 at 03:07:16PM +0800, Shan Hai wrote:
>> The simple definition of a macro is enough for the include guard, it's not
>> necessary to assign a value to it, so remove the assignment.
>>
>> Signed-off-by: Shan Hai <shan.hai@oracle.com>
> And what is the exact benefit of changing this?

The guard macro definition looks consistent with others, that's all :)

Thanks
Shan Hai